-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue reading castep's lattice_abc #107
Comments
Thanks for reporting, I'll get to this when I can! |
Coming back to this 18months later, I see that this fix is no longer enough as Replacing this call with
seems to work. I could make a pull request for this - however, I think there is probably a more elegant python fix, so would prefer to defer to a more competent python coder! |
Thanks for the investigation and reminder Jonathan, I'll take a look. |
@utf I've had a look at this and run into a problem: Do you know of any functionality in Pymatgen to standardise the cell to lower-triangular? It's easy in ASE... |
@jryates Looking at |
Line 81 of io/castep.py is
lengths_and_angles = lattice_abc[1:]
This causes an error, I think the correct line is
lengths_and_angles = lattice_abc
This is the section of code which reads a lattice_abc block - specifically the case in which we haven't passed a unit line (and hence we don't need to strip out the 1st row)
I didn't make a pull request because the run then gives a warning:
DeprecationWarning: from_lengths_and_angles is deprecated Use Lattice.from_parameters instead. This will be removed in v2020.*
So I thought it might be better to fix the two things at the same time. I'm still getting the hang of python, so I'll defer to @ajjackson
The text was updated successfully, but these errors were encountered: