Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call to strncat_s missing arg? #40

Open
woollybah opened this issue Aug 2, 2018 · 1 comment
Open

Call to strncat_s missing arg? #40

woollybah opened this issue Aug 2, 2018 · 1 comment
Assignees

Comments

@woollybah
Copy link

Platform : Win32, x64, MinGW 7.2

You seem to be missing a dest size argument here :

strncat_s(text, sendSuffix, availableChars);

@Luke1410
Copy link
Member

Luke1410 commented Aug 6, 2018

Not quite. text is a char array with a fixed size (REMOTE_MAX_TEXT_INPUT) (ln 75). Therefore, the templated version of strncat_s() is used and the size of the destination buffer doesn't need to be specified as another argument by the caller.

Please note that we don't test explicitly on MinGW atm. Adding support is on our mid-term roadmap (internal case number: SLNET-237). Do you suggest that the code line there triggers a compile error atm with MinGW?

@Luke1410 Luke1410 self-assigned this Aug 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants