New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add general PR checks #106

Open

oxcabe opened this issue Mar 15, 2024 · 0 comments

Assignees

Labels

enhancement integration

Member

oxcabe commented Mar 15, 2024 •

edited

Loading

Description

As of now, PRs targeting main only ensure that the project is built. The following checks have to be implemented as well:

Running unit tests.
Run commitlint against PR titles and main branch commits.
Linting and formatting modified JavaScript/TypeScript files with BiomeJS.
Linting and formatting modified style files with stylelint.
Linting and formatting modified workflows with actionlint.
Sorting the package.json with sort-package-json.

This also means it might be interesting to adopt a build system, such as Nx. This should be discussed in a different issue.

UPDATE: To be discussed in #92

The text was updated successfully, but these errors were encountered:

oxcabe added enhancement integration labels

oxcabe self-assigned this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment