Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI parameter for engine start mode #1547

Closed
3 tasks
heinezen opened this issue Sep 17, 2023 · 0 comments · Fixed by #1551
Closed
3 tasks

CLI parameter for engine start mode #1547

heinezen opened this issue Sep 17, 2023 · 0 comments · Fixed by #1551
Labels
area: simulation Involved in the game mechanics and simulation good first issue Suitable for newcomers lang: c++ Done in C++ code lang: cython Implemented using Cython code lang: python Done in Python code nice new thing ☺ A new feature that was not there before

Comments

@heinezen
Copy link
Member

Required Skills: Python, some C++

Difficulty: Easy

The engine start mode should be configurable via the CLI. There are only 2 relevant start mode right now:

  • full: starts game simulation with graphics
  • headless: starts game simulation without graphics (mainly for MP servers)

The parameters should be defined in the Python CLI and then passed through to the engine instantiation.

Tasks:

  • Define parameters in Python for submodules main and game
  • Pass engine mode to C++ invocation main_arguments struct
  • In C++, pass engine mode to Engine constructor
@heinezen heinezen added improvement Enhancement of an existing component lang: c++ Done in C++ code lang: python Done in Python code area: simulation Involved in the game mechanics and simulation good first issue Suitable for newcomers lang: cython Implemented using Cython code labels Sep 17, 2023
@heinezen heinezen moved this from 📋 Backlog to 🔖 TODO in openage game simulation Sep 17, 2023
@heinezen heinezen added nice new thing ☺ A new feature that was not there before and removed improvement Enhancement of an existing component labels Sep 17, 2023
tslocum added a commit to tslocum/openage that referenced this issue Sep 23, 2023
@tslocum
Add CLI parameter for running without graphics
c2a09e4 
Resolves SFTtech#1547.
@tslocum tslocum mentioned this issue Sep 23, 2023
Merged
tslocum added a commit to tslocum/openage that referenced this issue Sep 23, 2023
@tslocum
Add CLI parameter for running without graphics
5e5e027 
Resolves SFTtech#1547.
tslocum added a commit to tslocum/openage that referenced this issue Sep 23, 2023
@tslocum
Add CLI parameter for running without graphics
0d3bd2f 
Resolves SFTtech#1547.
tslocum added a commit to tslocum/openage that referenced this issue Sep 24, 2023
@tslocum
Add CLI parameter for running without graphics
fb531fc 
Resolves SFTtech#1547.
@github-project-automation github-project-automation bot moved this from 🔖 TODO to ✅ Done in openage game simulation Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: simulation Involved in the game mechanics and simulation good first issue Suitable for newcomers lang: c++ Done in C++ code lang: cython Implemented using Cython code lang: python Done in Python code nice new thing ☺ A new feature that was not there before
Projects
openage beginner tasks
Archived in project
openage game simulation
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add CLI parameter for running without graphics tslocum/openage
1 participant
@heinezen