Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed point math constants #1544

Closed
1 task
heinezen opened this issue Sep 17, 2023 · 3 comments · Fixed by #1607
Closed
1 task

Fixed point math constants #1544

heinezen opened this issue Sep 17, 2023 · 3 comments · Fixed by #1607
Labels
good first issue Suitable for newcomers improvement Enhancement of an existing component lang: c++ Done in C++ code

Comments

@heinezen
Copy link
Member

heinezen commented Sep 17, 2023 •
edited
Loading

Required Skills: C++

Difficulty: Easy

It would be nice to have common math constants like pi defined using our fixed-point implementation, so that they can be used in fixed-point calculations with deterministic outcome. Floating point constants are already implemented here.

Tasks:

  • Define existing math constants also as fixed point

Further Reading
@heinezen heinezen added improvement Enhancement of an existing component lang: c++ Done in C++ code good first issue Suitable for newcomers labels Sep 17, 2023
@AyiStar AyiStar mentioned this issue Dec 1, 2023
Merged
@AyiStar
Copy link
Contributor

AyiStar commented Dec 2, 2023

@heinezen I opened a WIP PR for adding two fixed point constants, and would be happy to discuss about the implementation and add more constants if everything is ok.

@heinezen
Copy link
Member Author

heinezen commented Dec 2, 2023 •
edited
Loading

@AyiStar I've looked at it yesterday and have no complaints so far :)

@AyiStar
Copy link
Contributor

AyiStar commented Dec 4, 2023 •
edited
Loading

@heinezen Added the rest of the constants in the fixed PR.

@heinezen heinezen linked a pull request Dec 4, 2023 that will close this issue
Add math constants corresbonding to util/math_constants.h for FixedPoint #1607
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Suitable for newcomers improvement Enhancement of an existing component lang: c++ Done in C++ code
Projects
openage beginner tasks
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add math constants corresbonding to util/math_constants.h for FixedPoint AyiStar/openage
2 participants
@heinezen @AyiStar