Skip to content
This repository has been archived by the owner on Aug 1, 2022. It is now read-only.

AngelGUI #124

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

AngelGUI #124

wants to merge 13 commits into from

Conversation

PyroFire232
Copy link

Branched exclusively for the GUI system.

Lots of polish.
Made margins work correctly.
Fixed naming conventions, and named things more logically.
Less mess.
Added significantly more comments and documentation.
Merged relevant utilities into a set of GUI::Utilities*, i.e GUI::String, which will be particularly useful later for doing GUI glitch text, and GUI::Square, which is a rectangle system based on position (top left) and size (position+size for bottom right), instead of topleft/bottomright coordinates.
Panels without a parent are automatically docked to full screen for simplicity and code cleanliness, as it would otherwise require 2 different sets of alignment offsets.
Added docking to a corner (does not add to layout).

Progress notes:

  • Most files are more or less finalized, with the notable exceptions of Skin.as, and Menus/PauseMenu.as.
  • Several key features are not yet finished, namely higher functioning panels such as text entry and scrollpanel. These will be ported in due time.
  • No major changes to the existing angelscripts were made, with the exception of overriding the previous pausemenu so it will display, and a RootScript.as to load and render it.
  • Currently interested in getting feedback before finishing off the more difficult and involved gui elements and all of the menus.

@Saalvage
Copy link
Member

Sadly I think the scope of this PR is way too narrow, it doesn't actually showcase anything realized in the new GUI system and doesn't even remove the old GUI system.

@juanjp600
Copy link
Collaborator

juanjp600 commented May 29, 2021

Sadly I think the scope of this PR is way too narrow

I disagree. PRs this small are basically perfect.

I've tested the new GUI system and looked through its code, there are still a few problems but I think we can merge this if you proceed to replace our old system with this one. Most of the improvements I'd like to make would have to involve changes to AngelScript itself to add some syntactic improvements.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants