This repository has been archived by the owner on Aug 1, 2022. It is now read-only.
forked from Regalis11/scpcb
-
Notifications
You must be signed in to change notification settings - Fork 11
AngelGUI #124
Open
PyroFire232
wants to merge
13
commits into
SCP-CBN:main
Choose a base branch
from
PyroFire232:AngelGUI
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
AngelGUI #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rebased gui system mk2
Rebased. Intended to be just the gui system on its own.
…600-main update engine
Sadly I think the scope of this PR is way too narrow, it doesn't actually showcase anything realized in the new GUI system and doesn't even remove the old GUI system. |
I disagree. PRs this small are basically perfect. I've tested the new GUI system and looked through its code, there are still a few problems but I think we can merge this if you proceed to replace our old system with this one. Most of the improvements I'd like to make would have to involve changes to AngelScript itself to add some syntactic improvements. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branched exclusively for the GUI system.
Lots of polish.
Made margins work correctly.
Fixed naming conventions, and named things more logically.
Less mess.
Added significantly more comments and documentation.
Merged relevant utilities into a set of GUI::Utilities*, i.e GUI::String, which will be particularly useful later for doing GUI glitch text, and GUI::Square, which is a rectangle system based on position (top left) and size (position+size for bottom right), instead of topleft/bottomright coordinates.
Panels without a parent are automatically docked to full screen for simplicity and code cleanliness, as it would otherwise require 2 different sets of alignment offsets.
Added docking to a corner (does not add to layout).
Progress notes: