Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes for sdk approval #132

Merged
merged 56 commits into from
Dec 5, 2024
Merged

Changes for sdk approval #132

merged 56 commits into from
Dec 5, 2024

Conversation

Angelyr
Copy link
Contributor

@Angelyr Angelyr commented Nov 24, 2024

  • Removed usages of comm_world
  • Provide a runtime API to return the current version number of the software.
  • Have no hardwired print or IO statements that cannot be turned off.
  • Added doxygen documentation
  • Added smoke test
  • version comparison preprocessor macros.

Angelyr added 30 commits November 13, 2024 17:44
@Angelyr Angelyr requested a review from cwsmith as a code owner November 24, 2024 02:05
@Angelyr Angelyr requested review from jacobmerson and cwsmith and removed request for cwsmith November 24, 2024 02:06
@Angelyr Angelyr self-assigned this Nov 24, 2024
cwsmith
cwsmith reviewed Nov 25, 2024
View reviewed changes
Copy link
Contributor

@cwsmith cwsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you. A few comments are below.

CMakeLists.txt Outdated Show resolved Hide resolved
Doxyfile Outdated Show resolved Hide resolved
support/ppPrint.h Outdated Show resolved Hide resolved
support/CMakeLists.txt Outdated Show resolved Hide resolved
particle_structs/test/CMakeLists.txt Outdated Show resolved Hide resolved
src/pumipic_version.hpp Outdated Show resolved Hide resolved
jacobmerson
jacobmerson reviewed Nov 28, 2024
View reviewed changes
CMakeLists.txt Outdated Show resolved Hide resolved
test/pseudoXGCm_scatter.cpp Show resolved Hide resolved
support/ppPrint.h Show resolved Hide resolved
support/ppPrint.h Outdated Show resolved Hide resolved
support/ppPrint.h Outdated Show resolved Hide resolved
support/ppPrint.h Outdated Show resolved Hide resolved
support/ppPrint.h Outdated Show resolved Hide resolved
support/ppPrint.h Outdated Show resolved Hide resolved
support/ppTiming.cpp Outdated Show resolved Hide resolved
support/CMakeLists.txt Outdated Show resolved Hide resolved
@jacobmerson
Copy link
Contributor

Thanks Angel! I provided a few comments.

jacobmerson
jacobmerson approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@jacobmerson jacobmerson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates look good. Thanks!

@jacobmerson
Copy link
Contributor

@cwsmith do you want to review this before merge?

cwsmith
cwsmith approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@cwsmith cwsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you. I just had one question below.

src/CMakeLists.txt Outdated Show resolved Hide resolved
@jacobmerson
Copy link
Contributor

Looks good. Thanks Angel!

@cwsmith cwsmith merged commit b6678b0 into master Dec 5, 2024
2 checks passed
@cwsmith cwsmith deleted the ac/xsdk-changes branch December 5, 2024 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobmerson jacobmerson jacobmerson approved these changes

@cwsmith cwsmith cwsmith approved these changes

Assignees

@Angelyr Angelyr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Angelyr @jacobmerson @cwsmith