Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong username on chat #466

Closed
josemvidal opened this issue Apr 1, 2024 · 5 comments · Fixed by #478
Closed

Wrong username on chat #466

josemvidal opened this issue Apr 1, 2024 · 5 comments · Fixed by #478
Assignees
Labels
bug Something isn't working
Milestone

Comments

@josemvidal
Copy link
Member

2024-04-01_14-55-40.mp4
@josemvidal josemvidal added the bug Something isn't working label Apr 1, 2024
@josemvidal josemvidal added this to the RC1 Release milestone Apr 1, 2024
@evan-scales
Copy link
Collaborator

Weird, can you provide some steps to reproduce? Are you logged into 'nuqihykug' on another tab? Whenever I've tested sending messages I login to the second account in an incognito tab. But I haven't tested what happens if not logging in to the second account from incognito

@evan-scales
Copy link
Collaborator

Was able to reproduce. STR

  1. Login to account 1
  2. Open a new non incognito tab and login to account 2
  3. Switch back to tab from step 1 (don't refresh page at all)
  4. Send a chat message

Expected: Message is sent from account 1
Actual: Message is sent from account 2

Happening because the jwt token is saved in the local storage. We send that jwt token to the api when needed. Logging in on a new tab overrides that jwt token, but navigation header makes it seem as account 1 is still the active user.

@evan-scales evan-scales self-assigned this Apr 1, 2024
@MPSharp
Copy link

MPSharp commented Apr 3, 2024

I found the same issues, when creating events while logged in twice on the same machine.

@MPSharp
Copy link

MPSharp commented Apr 3, 2024

2024-04-03.11-56-16.mp4

@MPSharp
Copy link

MPSharp commented Apr 3, 2024

as for chatting confirmed.

2024-04-03.11-53-40.mp4

@evan-scales evan-scales linked a pull request Apr 6, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants