From f6d361fa22b98c007ca9561a0fcb06b4bf908454 Mon Sep 17 00:00:00 2001 From: Mehmet Can Ay Date: Tue, 4 Feb 2025 14:35:42 +0100 Subject: [PATCH 1/3] fix: unpacking issue --- api/routes.py | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/api/routes.py b/api/routes.py index 7efbe8e..d0d797e 100644 --- a/api/routes.py +++ b/api/routes.py @@ -186,14 +186,14 @@ async def create_mapping(concept_id: str, @app.post("/mappings", tags=["mappings"]) -async def get_closest_mappings_for_text(text: str, - terminology_name: str = "SNOMED CT", - model: str = "sentence-transformers/all-mpnet-base-v2", - limit: int = 5): +async def get_closest_mappings_for_text(text: str = Form(...), + terminology_name: str = Form("SNOMED CT"), + model: str = Form("sentence-transformers/all-mpnet-base-v2"), + limit: int = Form(5)): try: embedding_model = MPNetAdapter(model) - embedding = embedding_model.get_embedding(text).tolist() - closest_mappings = repository.get_terminology_and_model_specific_closest_mappings(embedding, terminology_name, model, limit) + embedding = embedding_model.get_embedding(text) + closest_mappings = repository.get_terminology_and_model_specific_closest_mappings_with_similarities(embedding, terminology_name, model, limit) mappings = [] for mapping, similarity in closest_mappings: concept = mapping.concept From dd66287e6460bf8a4652a26a3939bd8673900ae8 Mon Sep 17 00:00:00 2001 From: Mehmet Can Ay Date: Tue, 4 Feb 2025 14:38:42 +0100 Subject: [PATCH 2/3] fix: name collision --- api/routes.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/api/routes.py b/api/routes.py index d0d797e..d4c1644 100644 --- a/api/routes.py +++ b/api/routes.py @@ -75,12 +75,12 @@ def connect_to_remote_weaviate_repository(): @app.get("/", include_in_schema=False) -def swagger_redirect(): +def root_redirect(): return RedirectResponse(url='/docs') @app.get("/v1", include_in_schema=False) -def swagger_redirect(): +def v1_redirect(): return RedirectResponse(url='/docs') From b024835bf36e3f4bf6a6f943670896187389467d Mon Sep 17 00:00:00 2001 From: Mehmet Can Ay Date: Tue, 4 Feb 2025 14:39:28 +0100 Subject: [PATCH 3/3] refactor: change limit into a Form for better communication with frontend --- api/routes.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/api/routes.py b/api/routes.py index d4c1644..d079797 100644 --- a/api/routes.py +++ b/api/routes.py @@ -224,7 +224,7 @@ async def get_closest_mappings_for_dictionary( terminology_name: str = Form("SNOMED CT"), variable_field: str = Form("variable"), description_field: str = Form("description"), - limit: int = 5 + limit: int = Form(5) ): try: embedding_model = MPNetAdapter(model)