Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HOW to use the ColmapForVisSatPatched #1

Open
ouyuanzheng opened this issue Apr 16, 2023 · 10 comments
Open

HOW to use the ColmapForVisSatPatched #1

ouyuanzheng opened this issue Apr 16, 2023 · 10 comments

Comments

@ouyuanzheng
Copy link

Hello, may I ask if the patch is used after installing Colmap or directly using the patch file during Colmap installation? I don't quite understand the specific process. Can you provide any suggestions?

@SBCV
Copy link
Owner

SBCV commented Apr 16, 2023

As you can see in the patches folder, the files which are replaced are source files (e.g. src__base__camera.cc).

Therefore, the patches must be applied before building the colmap library.

@ouyuanzheng
Copy link
Author

ouyuanzheng commented Apr 16, 2023 via email

@SBCV
Copy link
Owner

SBCV commented Apr 16, 2023

Have you build the original colmap library without errors?

@ouyuanzheng
Copy link
Author

ouyuanzheng commented Apr 16, 2023 via email

@SBCV
Copy link
Owner

SBCV commented Apr 16, 2023

What I mean is: build the standard colmap library first, following the instructions here, to see if everything (i.e. nvidia driver, cuda installation) is correctly set up.
Afterwards, try apply the patch files and build the project again.

@ouyuanzheng
Copy link
Author

ouyuanzheng commented Apr 16, 2023 via email

@SBCV
Copy link
Owner

SBCV commented Apr 16, 2023

I want to know the sentence 'Finally, apply the satellite specific patches with:
$PathToColmapForVisSatPatched/apply_ Patches. sh $PathToColmapToBePatched ", what should I do specifically?

I do not really understand your question. The command
$PathToColmapForVisSatPatched/apply_patches.sh $PathToColmapToBePatched
has to be executed in the terminal like all the other commands in the instructions, such as
chmod +x $PathToColmapForVisSatPatched/apply_patches.sh.
The variables $PathToColmapForVisSatPatched and $PathToColmapToBePatched are defined with

PathToColmapForVisSatPatched="/path/to/ColmapForVisSatPatched"
PathToColmapToBePatched="path/to/ColmapToBePatched"

as explained on the instruction page.

To summarize, you have to execute the following commands (in the terminal)

PathToColmapForVisSatPatched="/path/to/ColmapForVisSatPatched"
PathToColmapToBePatched="path/to/ColmapToBePatched"
git clone https://github.com/SBCV/ColmapForVisSatPatched.git $PathToColmapForVisSatPatched
git clone https://github.com/colmap/colmap.git $PathToColmapToBePatched
cd $PathToColmapToBePatched
git checkout 31df46c6c82bbdcaddbca180bc220d2eab9a1b5e
chmod +x $PathToColmapForVisSatPatched/apply_patches.sh
$PathToColmapForVisSatPatched/apply_patches.sh $PathToColmapToBePatched

Of course, you have to adapt the first two paths.

When installing colmap after installing this patch. Do I need to perform 
“apt get install nvidia driver 390 nvidia utils 390 nvidia cuda toolkit” of “ubuntu1804_install_dependencies.sh”file .

If cuda and the nvidia driver are already installed, you not need to change anything

@ouyuanzheng
Copy link
Author

ouyuanzheng commented Apr 16, 2023 via email

@WangYu0611
Copy link

Did you succeed install this patched?

@ouyuanzheng
Copy link
Author

ouyuanzheng commented Nov 24, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants