From f55d7a9b878f37f826bd9106f730eba012f6d904 Mon Sep 17 00:00:00 2001
From: Duc Vo Ngoc <duc.vo.ngoc@sap.com>
Date: Wed, 2 Oct 2024 13:56:30 +0200
Subject: [PATCH] fix(ui5-table): remove focus outline for selection cell

---
 packages/main/src/themes/TableRowBase.css | 8 +++++++-
 packages/main/test/pages/Table.html       | 2 +-
 2 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/packages/main/src/themes/TableRowBase.css b/packages/main/src/themes/TableRowBase.css
index 6af56bc22633..7814b5c22603 100644
--- a/packages/main/src/themes/TableRowBase.css
+++ b/packages/main/src/themes/TableRowBase.css
@@ -26,9 +26,15 @@
 }
 
 /** Focus outline for the selection cell */
-:host([tabindex]:focus) #selection-cell {
+:host([tabindex]:focus) #selection-cell:not(:has(~ #popin-cell)) {
     outline: none;
     box-shadow: var(--_ui5_table_shadow_border_top),
 				var(--_ui5_table_shadow_border_left),
 				var(--_ui5_table_shadow_border_bottom); /* There is a 1px difference between row and cell, therefore the outline is also 1px difference between their outline offsets */
 }
+
+:host([tabindex]:focus) #selection-cell:has(~ #popin-cell) {
+    outline: none;
+    box-shadow: var(--_ui5_table_shadow_border_top),
+				var(--_ui5_table_shadow_border_left);
+}
diff --git a/packages/main/test/pages/Table.html b/packages/main/test/pages/Table.html
index 389b196e0435..d70f1289a95c 100644
--- a/packages/main/test/pages/Table.html
+++ b/packages/main/test/pages/Table.html
@@ -23,7 +23,7 @@
 			label-interval="0"></ui5-slider>
 	</ui5-bar>
 
-	<ui5-table id="table" overflow-mode="Scroll" accessible-name-ref="title">
+	<ui5-table id="table" overflow-mode="Popin" accessible-name-ref="title">
 		<ui5-table-growing id="growing" type="Scroll" slot="features"></ui5-table-growing>
 		<ui5-table-selection id="selection" selected="0 2" slot="features"></ui5-table-selection>
 		<ui5-table-header-row slot="headerRow" sticky>