Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(framework): enable 72Blackfull font-family #7918

Merged
merged 3 commits into from
Nov 26, 2023
Merged

Conversation

ilhan007
Copy link
Member

@ilhan007 ilhan007 commented Nov 24, 2023

Font 72Blackfull was missing from our font styles and now added. This caused unexpected font issues when --sapFontBlackFamily variable is used.

Fixes: #7800

Before - ń is thinner than the rest:
Screenshot 2023-11-24 at 23 07 12

After (patching it in place) - ń is as thick as the rest:
Screenshot 2023-11-24 at 23 05 54

nnaydenow
nnaydenow previously approved these changes Nov 25, 2023
@nnaydenow nnaydenow dismissed their stale review November 25, 2023 12:50

Have question

Copy link
Contributor

@nnaydenow nnaydenow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For most of the url we have ui5-webcomponents parameter. Is it intendedly not added here?

@ilhan007
Copy link
Member Author

For most of the url we have ui5-webcomponents parameter. Is it intendedly not added here?

No intention, it does not make difference, but I am adding it for consistency

@ilhan007 ilhan007 merged commit 214780f into main Nov 26, 2023
7 checks passed
@ilhan007 ilhan007 deleted the fix-72Blackfull-font branch November 26, 2023 10:54
PetyaMarkovaBogdanova pushed a commit that referenced this pull request Dec 5, 2023
Font 72Blackfull was missing from our font styles and now added. This caused unexpected font issues when --sapFontBlackFamily variable is used.

Fixes: #7800
ilhan007 added a commit that referenced this pull request Dec 9, 2023
Font 72Blackfull was missing from our font styles and now added. This caused unexpected font issues when --sapFontBlackFamily variable is used.

Fixes: #7800
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

font-family '72Black' does not support Polish character ń
2 participants