Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Table]: Table is misaligned in latest 1.x version #9994

Open
1 task done
shubhamnazare opened this issue Oct 9, 2024 · 4 comments
Open
1 task done

[Table]: Table is misaligned in latest 1.x version #9994

shubhamnazare opened this issue Oct 9, 2024 · 4 comments
Labels

Comments

@shubhamnazare
Copy link

shubhamnazare commented Oct 9, 2024

Bug Description

After upgrading UI5WC to 1.24.11 and UI5WC4R to 1.29.11, the table is aligned centered instead of top.

Before upgrade -
Screenshot 2024-10-09 at 2 26 11 PM

After upgrade -
Screenshot 2024-10-09 at 2 26 22 PM

I did comparison between the DOM elements and their styles. I observed that height: 100% styles has been applied to ui5-table-root because of which I was seeing this issue. This change was added in this PR: https://github.com/SAP/ui5-webcomponents/pull/9768/files#diff-d338227a4cd8dc70f44df0ee56719f30ebb0020de18f7b8b83bedc90d0b0301d

If this is not an issue as per design, then please suggest any workaround.

Affected Component

No response

Expected Behaviour

Table should be aligned at the top instead of center.

Isolated Example

Example with ui5wc 1.23.3: https://stackblitz.com/edit/vitejs-vite-gpadav?file=package.json,src%2FApp.jsx
Example with ui5wc 1.24.11: https://stackblitz.com/edit/vitejs-vite-kwe4f8?file=package.json,src%2FApp.jsx

As you can see in the above examples, the table is aligned at the top in 1.23.3 but in 1.24.11 it is aligned in the center.

Steps to Reproduce

...

Log Output, Stack Trace or Screenshots

No response

Priority

Medium

UI5 Web Components Version

1.24.11

Browser

Chrome

Operating System

No response

Additional Context

No response

Organization

No response

Declaration

  • I’m not disclosing any internal or sensitive information.
@shubhamnazare shubhamnazare added the bug This issue is a bug in the code label Oct 9, 2024
@shubhamnazare shubhamnazare changed the title [Table]: Table content misaligned in latest 1.x version [Table]: Table is misaligned in latest 1.x version Oct 9, 2024
@NHristov-sap
Copy link
Contributor

Hi @shubhamnazare ,

Can you please provide live example that demonstrates the issue?

Best Regards,
Nikolay Hristov

@shubhamnazare
Copy link
Author

Hi @NHristov-sap

Here is the live example that demonstrates the issue -

Example with ui5wc 1.23.3: https://stackblitz.com/edit/vitejs-vite-gpadav?file=package.json,src%2FApp.jsx
Example with ui5wc 1.24.11: https://stackblitz.com/edit/vitejs-vite-kwe4f8?file=package.json,src%2FApp.jsx

As you can see in the above examples, the table is aligned at the top in 1.23.3 but in 1.24.11 it is aligned in the center.

@NHristov-sap
Copy link
Contributor

Hello @SAP/ui5-webcomponents-topic-tbl,

the issue is reproducible, see the provided snippets above.

Best Regards,
Nikolay Hristov

@DonkeyCo
Copy link
Member

Hi @SAP/ui5-webcomponents-core,

this issue is regarding the V1 table. Could you please have a look here?

Best regards,
Duc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

No branches or pull requests

3 participants