Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Menu][MenuItem]: MenuItem font size has changed in ui5-webcomponents 1.24.11 #9986

Open
1 task done
shubhamnazare opened this issue Oct 7, 2024 · 2 comments
Open
1 task done
Assignees
Labels
bug This issue is a bug in the code Low Prio TOPIC B

Comments

@shubhamnazare
Copy link

Bug Description

After upgrading ui5-webcomponents to 1.24.11 and ui5-webcomponents-react to 1.29.11, the font size in menu looks larger.

before upgrade example: https://stackblitz.com/edit/vitejs-vite-jxd18i?file=src%2FApp.jsx,package.json
after upgrade example: https://stackblitz.com/edit/vitejs-vite-sscnqt?file=src%2FApp.jsx,package.json

Affected Component

Menu, MenuItem

Expected Behaviour

The font size should have been the same as before in ui5-webcomponents 1.23.3.

Isolated Example

No response

Steps to Reproduce

...

Log Output, Stack Trace or Screenshots

No response

Priority

Medium

UI5 Web Components Version

1.24.11

Browser

Chrome

Operating System

No response

Additional Context

No response

Organization

No response

Declaration

  • I’m not disclosing any internal or sensitive information.
@shubhamnazare shubhamnazare added the bug This issue is a bug in the code label Oct 7, 2024
@hinzzx hinzzx self-assigned this Oct 8, 2024
@hinzzx
Copy link
Contributor

hinzzx commented Oct 8, 2024

Hi @SAP/ui5-webcomponents-topic-b ,

It seems that a font-size CSS property is missing in the ui5-menu-items.

A possible solution would be, to add font-size: var(--sapFontSize); to the text in the MenuListItem.css;

Best Regards,
Stoyan

@shubhamnazare
Copy link
Author

Hi @hinzzx could you please let me know the ETA on this and in which patch the fix will be available?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug in the code Low Prio TOPIC B
Projects
Status: In Progress
Development

No branches or pull requests

2 participants