Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dialog]: Dialog width calculation does not take Button Text Width into consideration #10012

Open
1 task done
gitgdako opened this issue Oct 10, 2024 · 4 comments
Open
1 task done
Assignees
Labels
bug This issue is a bug in the code TOPIC RD

Comments

@gitgdako
Copy link

Describe the bug

{ Dialog, Bar } from '@ui5/webcomponents-react';

Source Doc:
Dialog: https://sap.github.io/ui5-webcomponents-react/v2/?path=/docs/modals-popovers-dialog--docs
Dialog Styling with MessageViewButton:
https://experience.sap.com/wp-content/uploads/sites/56/2021/11/message-popover_overview_1.96.png
https://experience.sap.com/fiori-design-web/messaging/#message-popover

Using a dialog as described in your documentation with a small content and long Button Text, the Button Text is truncated.
This is even more of an issue if as described in the linked Fiori Doc you have a Save and a Close Button as well as Space for the MessageViewButton.
In the stackblitz as well as in your storybook the dialog has a min-width of 20rem, which our local implementation does not get automatically, therefore amplifying the issue. Setting that value was our fix for now as well

I am very sure that this behaviour has changed from webcomponents 2.2 to 2.3 (maybe the min-width got lost), but we can not easily verify that. Either way this is likely a webcomponents issue

      <Dialog
        footer={
          <Bar
            design="Footer"
            endContent={
              <Button onClick={() => setOpen(false)}>
                This is a very long text that exceeds the calculated width of
                the dialog
              </Button>
            }
          />
        }
        headerText="Dialog Header"
        open={open}
      />

Isolated Example

https://stackblitz.com/edit/github-lqbaqm

Reproduction steps

  1. https://stackblitz.com/edit/github-lqbaqm
  2. Click Button -> Dialog opens
  3. Text is truncated

Expected Behaviour

(Up to a reasonable max-width) the content of the footer is taking into consideration when calculating the dialog width

Screenshots or Videos

No response

UI5 Web Components for React Version

2.2.0

UI5 Web Components Version

2.3.0

Browser

Chrome

Operating System

Windows 11

Additional Context

No response

Relevant log output

No response

Organization

No response

Declaration

  • I’m not disclosing any internal or sensitive information.
@gitgdako gitgdako added the bug This issue is a bug in the code label Oct 10, 2024
@Lukas742
Copy link
Collaborator

Thanks for reporting! I'll forward this issue to our UI5 Web Components Colleagues as the affected component is developed in their repository.

@Lukas742 Lukas742 transferred this issue from SAP/ui5-webcomponents-react Oct 14, 2024
@PetyaMarkovaBogdanova PetyaMarkovaBogdanova self-assigned this Oct 14, 2024
@PetyaMarkovaBogdanova
Copy link
Contributor

Hi team,
I noticed that in current implementation the Dialog footer uses ui5-toolbar, while in the prepared use-case it is ui5-bar.
Can you, please, check where the difference in the max-width of the button is coming from?
Best regards,
Petya Markova.
(UI5 Dispatcher)

@gitgdako
Copy link
Author

Hi. The given code is from your sourcecode in
https://sap.github.io/ui5-webcomponents-react/v2/?path=/docs/modals-popovers-dialog--docs#example

But using the new Toolbar instead of a Bar leads to moving the action into an overflow menu instead of cropping
image

@PetyaMarkovaBogdanova PetyaMarkovaBogdanova removed their assignment Oct 14, 2024
@PetyaMarkovaBogdanova
Copy link
Contributor

Hi @gitgdako ,
I assigned the issue to the involved team and the handover message was targeting them.
They will take a look at the case and get back to you ASAP.
Best regards,
Petya Markova.
(UI5 Dispatcher)

@LidiyaGeorgieva LidiyaGeorgieva self-assigned this Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug in the code TOPIC RD
Projects
Status: New Issues
Development

No branches or pull requests

4 participants