You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Using a dialog as described in your documentation with a small content and long Button Text, the Button Text is truncated.
This is even more of an issue if as described in the linked Fiori Doc you have a Save and a Close Button as well as Space for the MessageViewButton.
In the stackblitz as well as in your storybook the dialog has a min-width of 20rem, which our local implementation does not get automatically, therefore amplifying the issue. Setting that value was our fix for now as well
I am very sure that this behaviour has changed from webcomponents 2.2 to 2.3 (maybe the min-width got lost), but we can not easily verify that. Either way this is likely a webcomponents issue
<Dialog
footer={
<Bar
design="Footer"
endContent={
<Button onClick={() => setOpen(false)}>
This is a very long text that exceeds the calculated width of
the dialog
</Button>
}
/>
}
headerText="Dialog Header"
open={open}
/>
Hi team,
I noticed that in current implementation the Dialog footer uses ui5-toolbar, while in the prepared use-case it is ui5-bar.
Can you, please, check where the difference in the max-width of the button is coming from?
Best regards,
Petya Markova.
(UI5 Dispatcher)
Hi @gitgdako ,
I assigned the issue to the involved team and the handover message was targeting them.
They will take a look at the case and get back to you ASAP.
Best regards,
Petya Markova.
(UI5 Dispatcher)
Describe the bug
{ Dialog, Bar } from '@ui5/webcomponents-react';
Source Doc:
Dialog: https://sap.github.io/ui5-webcomponents-react/v2/?path=/docs/modals-popovers-dialog--docs
Dialog Styling with MessageViewButton:
https://experience.sap.com/wp-content/uploads/sites/56/2021/11/message-popover_overview_1.96.png
https://experience.sap.com/fiori-design-web/messaging/#message-popover
Using a dialog as described in your documentation with a small content and long Button Text, the Button Text is truncated.
This is even more of an issue if as described in the linked Fiori Doc you have a Save and a Close Button as well as Space for the MessageViewButton.
In the stackblitz as well as in your storybook the dialog has a min-width of 20rem, which our local implementation does not get automatically, therefore amplifying the issue. Setting that value was our fix for now as well
I am very sure that this behaviour has changed from webcomponents 2.2 to 2.3 (maybe the min-width got lost), but we can not easily verify that. Either way this is likely a webcomponents issue
Isolated Example
https://stackblitz.com/edit/github-lqbaqm
Reproduction steps
Expected Behaviour
(Up to a reasonable max-width) the content of the footer is taking into consideration when calculating the dialog width
Screenshots or Videos
No response
UI5 Web Components for React Version
2.2.0
UI5 Web Components Version
2.3.0
Browser
Chrome
Operating System
Windows 11
Additional Context
No response
Relevant log output
No response
Organization
No response
Declaration
The text was updated successfully, but these errors were encountered: