Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ui5-menu | Accessibility]: Focus not shifting to the first element when the menu has dynamic content #7237

Open
1 task done
rv97 opened this issue Jun 21, 2023 · 9 comments · May be fixed by #10005
Open
1 task done

[ui5-menu | Accessibility]: Focus not shifting to the first element when the menu has dynamic content #7237

rv97 opened this issue Jun 21, 2023 · 9 comments · May be fixed by #10005
Assignees
@tsanislavgatev
Labels
ACC bug This issue is a bug in the code Medium Prio TOPIC B

Comments

@rv97
Copy link

rv97 commented Jun 21, 2023

Bug Description

When the ui5-menu menu or the sub-menu has menu items that are loaded dynamically after showing the busy indicator, the focus does not shift to the first element after the menu loads.

Video: https://sap-my.sharepoint.com/:v:/p/vignesh_r02/ER0q_uLNU6BAi_YC6vqG1XIBxyXKiXFaktR7ya0Dj_-ggw?e=tAbArb

Affected Component

ui5-menu, ui5-menu-item

Expected Behaviour

When i hit enter on a menu or sub-menu with dynamic menu items, after the busy indicator, the focus should go to the first element.

Isolated Example

https://sap-my.sharepoint.com/:v:/p/vignesh_r02/ER0q_uLNU6BAi_YC6vqG1XIBxyXKiXFaktR7ya0Dj_-ggw?e=tAbArb

Steps to Reproduce

This can be reproduced in the ui5-documentation itself.

  1. Hit tab and go to the menu with dynamic content
  2. Hit enter
  3. After the menu loads, the you can see the focus is not there for the first element
    ...

Log Output, Stack Trace or Screenshots

No response

Priority

None

UI5 Web Components Version

1.14.0

Browser

Chrome

Operating System

No response

Additional Context

No response

Organization

SAP Labs

Declaration

  • I’m not disclosing any internal or sensitive information.
@rv97 rv97 added the bug This issue is a bug in the code label Jun 21, 2023
@unazko unazko self-assigned this Jun 21, 2023
@unazko
Copy link
Contributor

unazko commented Jun 21, 2023

Hello @SAP/ui5-webcomponents-topic-b,

The issue is reproducible as described by @rv97.
When the busy indicator gets removed and the new items are added the focus should be applied into the first element of the list.

We should contact keyboard handling experts and discuss if the busy indicators should be focusable as well.
Additionally we need to check if they are focusable what screen reader output we'll get.

Best regards,
Boyan

@rv97
Copy link
Author

rv97 commented Nov 27, 2023

Hi @unazko ,

Is there any update on this?

@DMihaylova
Copy link

Hi @rv97,

We're currently working on fixing your issue and will keep you updated.
Thank you for your patience!

Regards,
Diana

@rv97
Copy link
Author

rv97 commented May 9, 2024

Hi @DMihaylova ,

Thanks for the update.

Regards,
Vignesh R

@Abanindra
Copy link

Hi @DMihaylova ,

Appreciate if you can share an update regarding in which version of ui5-webcomponents and ui5-webcomponents-react we will expect the fix?

regards
Aban

@DMihaylova
Copy link

Hi @Abanindra,

We are currently addressing some technical issues that have impacted our progress on your requirement. As a result, I cannot provide a precise completion date at this time. Please rest assured that we are working diligently to resolve these issues and will keep you updated on our progress.

Thank you for your understanding and patience.

Regards,
Diana

@unazko unazko assigned tsanislavgatev and unassigned unazko Aug 27, 2024
@shubhamnazare
Copy link

Hi @DMihaylova
Could you please let me know what is the current progress?

@shubhamnazare
Copy link

Hi @DMihaylova , @tsanislavgatev

Please let us know what is the status of this issue.

@DMihaylova
Copy link

Hi @shubhamnazare,

We continue the work on this issue.
Since it's not a trivial one, we expanded our collaboration in order to fix it.

Thanks for your understanding!

Regards,
Diana

@tsanislavgatev tsanislavgatev linked a pull request Oct 10, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsanislavgatev tsanislavgatev

Labels
ACC bug This issue is a bug in the code Medium Prio TOPIC B
Projects
Maintenance - Topic B
Status: In Progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ui5-menu): focus first element after adding new items SAP/ui5-webcomponents
6 participants
@tsanislavgatev @DMihaylova @unazko @Abanindra @rv97 @shubhamnazare