-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dialog: Dialog content alignment issue with zoom #10000
Comments
Fixing this issue is very important for accessible users who are using mobile devices. |
Thanks for reporting! I'll forward this issue to our UI5 Web Components Colleagues as the affected component is developed in their repository. |
Hello @SAP/ui5-webcomponents-topic-rd, Please check if this is valid use case. Best Regards, |
Hello @saurabhmehta02 , Kindly provide more detailed steps for reproducing the issue along with a screenshot. Also, there seems to be a discrepancy between the title and the description: the title mentions "zoom," while the description refers to "Set base font size to above 24px or higher..." Best Regards, |
Dialog rendering when base font size is 16px: Dialog rendering when base font size is 28px: Dialog rendering when base font size is 32px: @LidiyaGeorgieva I hope above screenshots are enough for you to understand the issue. We are using the web module creating using the dialog component in mobile app, its zoom in the mobile device (for accessible users). The font size in the web module is adjusted dynamically according to the zoom level on the mobile device. |
Hello @saurabhmehta02 , Please be more specific how you "Set base font size to above 24px or higher"? Best Regards, |
Hi @LidiyaGeorgieva As I mentioned previously, in our use case the web module is being used in the mobile app too. Thanks, |
@LidiyaGeorgieva If you want to reproduce in the component demo page, please use dev tools and open the dialog component in mobile view (which have done already) and then in the console run following script: Thanks, |
Hello @saurabhmehta02 , After following your steps, the dialog appears fine and I don't see any issues: Please provide an isolated, reproducible example of the problem, or we’ll need to close the ticket. Best Regards, |
@LidiyaGeorgieva I am attaching the sample react app and two recordings. Steps to run the app: It should ideally run on port 3000 so URL should be localhost:3000. Recording2.movIssue_recording.mov |
Describe the bug
We have developed UI components using the web component and these are also used in mobile app.
In mobile devices for accessibility purpose, user can use dynamic font size setting and increase the font size.
If we increase the base font by 1.5x or 2x (base font size at html root is 24px or 32px) then web components sets left position in negative in mobile view.
For example:
if base font size is 30px then styles becomes: left: -85px
if base font size is 32px then styles becomes: left: -105px
Because of this left style, the dialog content isn't aligned in mobile resolution with higher font size.
Isolated Example
No response
Reproduction steps
Navigate to https://sap.github.io/ui5-webcomponents-react/v1/?path=/story/modals-popovers-dialog--with-content&args=stretch:!true
Open chrome dev tools and enable mobile view
Set base font size to above 24px or higher and you can notice inline style is added at the dialog level and because of which the dialog content isn't aligned
Expected Behaviour
No response
Screenshots or Videos
No response
UI5 Web Components for React Version
1.24.0
UI5 Web Components Version
1.21.0
Browser
Chrome, Safari
Operating System
iOS and Android
Additional Context
No response
Relevant log output
No response
Organization
SAP Labs
Declaration
The text was updated successfully, but these errors were encountered: