From 864ec643f7b8e6184407f486b4482c60edf408d7 Mon Sep 17 00:00:00 2001 From: Petar Dimov Date: Wed, 5 Jul 2023 11:28:13 +0300 Subject: [PATCH] fix: semantic tabs colors in HC themes --- packages/main/src/themes/TabInStrip.css | 8 ++++---- .../src/themes/base/TabContainer-parameters.css | 1 - .../sap_belize_hcb/TabContainer-parameters.css | 1 - .../sap_belize_hcw/TabContainer-parameters.css | 1 - .../sap_fiori_3_hcb/TabContainer-parameters.css | 1 - .../sap_fiori_3_hcw/TabContainer-parameters.css | 1 - .../sap_horizon_hcb/TabContainer-parameters.css | 17 ++++++++--------- .../sap_horizon_hcw/TabContainer-parameters.css | 17 ++++++++--------- 8 files changed, 20 insertions(+), 27 deletions(-) diff --git a/packages/main/src/themes/TabInStrip.css b/packages/main/src/themes/TabInStrip.css index 90aae3f9d408..7cdc67d2b390 100644 --- a/packages/main/src/themes/TabInStrip.css +++ b/packages/main/src/themes/TabInStrip.css @@ -299,7 +299,7 @@ /*** Semantic states ***/ .ui5-tab-strip-item--positive.ui5-tab-strip-item--textOnly .ui5-tab-strip-itemText, .ui5-tab-strip-item--positive .ui5-tab-strip-item-icon-outer { - color: var(--sapPositiveColor); + color: var(--_ui5_tc_headerItem_positive_color); border-color: var(--_ui5_tc_headerItem_positive_selected_border_color); } @@ -330,7 +330,7 @@ .ui5-tab-strip-item--negative.ui5-tab-strip-item--textOnly .ui5-tab-strip-itemText, .ui5-tab-strip-item--negative .ui5-tab-strip-item-icon-outer { - color: var(--sapNegativeColor); + color: var(--_ui5_tc_headerItem_negative_color); border-color: var(--_ui5_tc_headerItem_negative_selected_border_color); } @@ -354,7 +354,7 @@ .ui5-tab-strip-item--critical.ui5-tab-strip-item--textOnly .ui5-tab-strip-itemText, .ui5-tab-strip-item--critical .ui5-tab-strip-item-icon-outer { - color: var(--sapCriticalColor); + color: var(--_ui5_tc_headerItem_critical_color); border-color: var(--_ui5_tc_headerItem_critical_selected_border_color); } @@ -378,7 +378,7 @@ .ui5-tab-strip-item--neutral.ui5-tab-strip-item--textOnly .ui5-tab-strip-itemText, .ui5-tab-strip-item--neutral .ui5-tab-strip-item-icon-outer { - color: var(--sapNeutralColor); + color: var(--_ui5_tc_headerItem_neutral_color); border-color: var(--_ui5_tc_headerItem_neutral_selected_border_color); } diff --git a/packages/main/src/themes/base/TabContainer-parameters.css b/packages/main/src/themes/base/TabContainer-parameters.css index 196fa9f78b5c..1958c6f809dc 100644 --- a/packages/main/src/themes/base/TabContainer-parameters.css +++ b/packages/main/src/themes/base/TabContainer-parameters.css @@ -70,7 +70,6 @@ /* Overflow Item */ - --_ui5_tc_overflowItem_neutral_color: var(--sapNeutralColor); --_ui5_tc_overflowItem_positive_color: var(--sapPositiveColor); --_ui5_tc_overflowItem_negative_color: var(--sapNegativeColor); --_ui5_tc_overflowItem_critical_color: var(--sapCriticalColor); diff --git a/packages/main/src/themes/sap_belize_hcb/TabContainer-parameters.css b/packages/main/src/themes/sap_belize_hcb/TabContainer-parameters.css index 62de67f81295..3331f6cee46f 100644 --- a/packages/main/src/themes/sap_belize_hcb/TabContainer-parameters.css +++ b/packages/main/src/themes/sap_belize_hcb/TabContainer-parameters.css @@ -35,7 +35,6 @@ /* Overflow Item */ - --_ui5_tc_overflowItem_neutral_color: var(--sapGroup_TitleTextColor); --_ui5_tc_overflowItem_positive_color: var(--sapGroup_TitleTextColor); --_ui5_tc_overflowItem_negative_color: var(--sapGroup_TitleTextColor); --_ui5_tc_overflowItem_critical_color: var(--sapGroup_TitleTextColor); diff --git a/packages/main/src/themes/sap_belize_hcw/TabContainer-parameters.css b/packages/main/src/themes/sap_belize_hcw/TabContainer-parameters.css index 62de67f81295..3331f6cee46f 100644 --- a/packages/main/src/themes/sap_belize_hcw/TabContainer-parameters.css +++ b/packages/main/src/themes/sap_belize_hcw/TabContainer-parameters.css @@ -35,7 +35,6 @@ /* Overflow Item */ - --_ui5_tc_overflowItem_neutral_color: var(--sapGroup_TitleTextColor); --_ui5_tc_overflowItem_positive_color: var(--sapGroup_TitleTextColor); --_ui5_tc_overflowItem_negative_color: var(--sapGroup_TitleTextColor); --_ui5_tc_overflowItem_critical_color: var(--sapGroup_TitleTextColor); diff --git a/packages/main/src/themes/sap_fiori_3_hcb/TabContainer-parameters.css b/packages/main/src/themes/sap_fiori_3_hcb/TabContainer-parameters.css index 62de67f81295..3331f6cee46f 100644 --- a/packages/main/src/themes/sap_fiori_3_hcb/TabContainer-parameters.css +++ b/packages/main/src/themes/sap_fiori_3_hcb/TabContainer-parameters.css @@ -35,7 +35,6 @@ /* Overflow Item */ - --_ui5_tc_overflowItem_neutral_color: var(--sapGroup_TitleTextColor); --_ui5_tc_overflowItem_positive_color: var(--sapGroup_TitleTextColor); --_ui5_tc_overflowItem_negative_color: var(--sapGroup_TitleTextColor); --_ui5_tc_overflowItem_critical_color: var(--sapGroup_TitleTextColor); diff --git a/packages/main/src/themes/sap_fiori_3_hcw/TabContainer-parameters.css b/packages/main/src/themes/sap_fiori_3_hcw/TabContainer-parameters.css index 62de67f81295..3331f6cee46f 100644 --- a/packages/main/src/themes/sap_fiori_3_hcw/TabContainer-parameters.css +++ b/packages/main/src/themes/sap_fiori_3_hcw/TabContainer-parameters.css @@ -35,7 +35,6 @@ /* Overflow Item */ - --_ui5_tc_overflowItem_neutral_color: var(--sapGroup_TitleTextColor); --_ui5_tc_overflowItem_positive_color: var(--sapGroup_TitleTextColor); --_ui5_tc_overflowItem_negative_color: var(--sapGroup_TitleTextColor); --_ui5_tc_overflowItem_critical_color: var(--sapGroup_TitleTextColor); diff --git a/packages/main/src/themes/sap_horizon_hcb/TabContainer-parameters.css b/packages/main/src/themes/sap_horizon_hcb/TabContainer-parameters.css index ee7131b902b8..425980b7f817 100644 --- a/packages/main/src/themes/sap_horizon_hcb/TabContainer-parameters.css +++ b/packages/main/src/themes/sap_horizon_hcb/TabContainer-parameters.css @@ -8,10 +8,10 @@ --_ui5_tc_headerItem_focus_border: 0.125rem dotted var(--sapContent_FocusColor); --_ui5_tc_headerItem_text_selected_color: var(--sapPageHeader_BorderColor); --_ui5_tc_headerItem_text_selected_hover_color: var(--sapPageHeader_BorderColor); - --_ui5_tc_headerItem_neutral_color: var(--sapGroup_TitleTextColor); - --_ui5_tc_headerItem_positive_color: var(--sapGroup_TitleTextColor); - --_ui5_tc_headerItem_negative_color: var(--sapGroup_TitleTextColor); - --_ui5_tc_headerItem_critical_color: var(--sapGroup_TitleTextColor); + --_ui5_tc_headerItem_neutral_color: var(--sapTextColor); + --_ui5_tc_headerItem_positive_color: var(--sapTextColor); + --_ui5_tc_headerItem_negative_color: var(--sapTextColor); + --_ui5_tc_headerItem_critical_color: var(--sapTextColor); --_ui5_tc_headerItem_neutral_border_color: var(--_ui5_tc_headerItem_neutral_color); --_ui5_tc_headerItem_positive_border_color: var(--_ui5_tc_headerItem_positive_color); --_ui5_tc_headerItem_negative_border_color: var(--_ui5_tc_headerItem_negative_color); @@ -37,11 +37,10 @@ --_ui5_tc_headerItemIcon_semantic_selected_color: var(--sapContent_IconColor); /* Overflow Item */ - --_ui5_tc_overflowItem_neutral_color: var(--sapGroup_TitleTextColor); - --_ui5_tc_overflowItem_positive_color: var(--sapGroup_TitleTextColor); - --_ui5_tc_overflowItem_negative_color: var(--sapGroup_TitleTextColor); - --_ui5_tc_overflowItem_critical_color: var(--sapGroup_TitleTextColor); - --_ui5_tc_overflowItem_default_color: var(--sapGroup_TitleTextColor); + --_ui5_tc_overflowItem_positive_color: var(--sapTextColor); + --_ui5_tc_overflowItem_negative_color: var(--sapTextColor); + --_ui5_tc_overflowItem_critical_color: var(--sapTextColor); + --_ui5_tc_overflowItem_default_color: var(--sapTextColor); --_ui5_tc_overflowItem_current_color: var(--_ui5_tc_overflowItem_default_color); --_ui5_tc_overflowItem_extraIndent: 1rem; diff --git a/packages/main/src/themes/sap_horizon_hcw/TabContainer-parameters.css b/packages/main/src/themes/sap_horizon_hcw/TabContainer-parameters.css index ee7131b902b8..425980b7f817 100644 --- a/packages/main/src/themes/sap_horizon_hcw/TabContainer-parameters.css +++ b/packages/main/src/themes/sap_horizon_hcw/TabContainer-parameters.css @@ -8,10 +8,10 @@ --_ui5_tc_headerItem_focus_border: 0.125rem dotted var(--sapContent_FocusColor); --_ui5_tc_headerItem_text_selected_color: var(--sapPageHeader_BorderColor); --_ui5_tc_headerItem_text_selected_hover_color: var(--sapPageHeader_BorderColor); - --_ui5_tc_headerItem_neutral_color: var(--sapGroup_TitleTextColor); - --_ui5_tc_headerItem_positive_color: var(--sapGroup_TitleTextColor); - --_ui5_tc_headerItem_negative_color: var(--sapGroup_TitleTextColor); - --_ui5_tc_headerItem_critical_color: var(--sapGroup_TitleTextColor); + --_ui5_tc_headerItem_neutral_color: var(--sapTextColor); + --_ui5_tc_headerItem_positive_color: var(--sapTextColor); + --_ui5_tc_headerItem_negative_color: var(--sapTextColor); + --_ui5_tc_headerItem_critical_color: var(--sapTextColor); --_ui5_tc_headerItem_neutral_border_color: var(--_ui5_tc_headerItem_neutral_color); --_ui5_tc_headerItem_positive_border_color: var(--_ui5_tc_headerItem_positive_color); --_ui5_tc_headerItem_negative_border_color: var(--_ui5_tc_headerItem_negative_color); @@ -37,11 +37,10 @@ --_ui5_tc_headerItemIcon_semantic_selected_color: var(--sapContent_IconColor); /* Overflow Item */ - --_ui5_tc_overflowItem_neutral_color: var(--sapGroup_TitleTextColor); - --_ui5_tc_overflowItem_positive_color: var(--sapGroup_TitleTextColor); - --_ui5_tc_overflowItem_negative_color: var(--sapGroup_TitleTextColor); - --_ui5_tc_overflowItem_critical_color: var(--sapGroup_TitleTextColor); - --_ui5_tc_overflowItem_default_color: var(--sapGroup_TitleTextColor); + --_ui5_tc_overflowItem_positive_color: var(--sapTextColor); + --_ui5_tc_overflowItem_negative_color: var(--sapTextColor); + --_ui5_tc_overflowItem_critical_color: var(--sapTextColor); + --_ui5_tc_overflowItem_default_color: var(--sapTextColor); --_ui5_tc_overflowItem_current_color: var(--_ui5_tc_overflowItem_default_color); --_ui5_tc_overflowItem_extraIndent: 1rem;