-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not all properties have completion suggestions provided by enum lists #5
Comments
Hi @pubmikeb , regarding the The same applies to our For the models, especially the model types, we could foresee something like an enum but in addition we need to allow additional entries otherwise this would prevent the usage of custom models in the Would you be ok with this? THX and best regards, |
Hi @petermuessig,
I though, that both
That sounds complicated, perhaps a static generation of enums prior release of a new UI5 build for both: list of available libraries (
That can be OK. The key idea, I want to get a suggestions from the IDE what to write, at least for the default, not custom models. "models": {
"i18n": {
"settings": {
"bundleName": "webapp.i18n.i18n",
"bundleUrl": "i18n/i18n.properties",
"fallbackLocale": "en",
"supportedLocales": [
"en",
"de"
]
},
"type": "sap.ui.model.resource.ResourceModel"
}
}, But IDE doesn't provide any assistance for |
Hi @pubmikeb , we will investigate the option a bit more in depth to have recommendations by the IDE but in addition allow also free text entries. Regarding the language codes, we follow the BCP-47 syntax since we also need to have proper support for regions and not only for languages. In addition, for technical languages like pseudo translations we use the possibility to add additional variants. The ISO 639-1 is just the language code in the beginning. For the libs and minUI5Version we also may think about something like this - but as the manifests' lifecycle is independent from the UI5 lifecycle it might be a bit complicated with the static generation. Also some space for research I would suppose. I will take these points to the dev team for research and keep you posted... Best regards, |
Thanks a lot for the detailed explanation! Best regards, |
It would be great if all schema properties, which have a closed set of possible values would provide suggestions powered by
enum
, just like property_version
does.For instance, the following properties don't provide a code completion suggestions:
sap.app/i18n/supportedLocales
sap.app/i18n/fallbackLocale
sap.ui5/models/i18n/settings/supportedLocales
sap.ui5/models/i18n/settings/fallbackLocale
sap.ui5/dependencies/libs
sap.ui5/dependencies/minUI5Version
sap.ui5/models
That's the whole idea of a manifest JSON-schema — to assist a developer to choose a proper value from a closed set of possible ones. To save a time and not to go to an API documentation.
Ideally, every non-app-specific value should provide a suggestion.
The text was updated successfully, but these errors were encountered: