Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible incorrect pattern property for "sap.ui5.dependencies.libs" #24

Open
tsteckenborn opened this issue Apr 10, 2024 · 1 comment
Open

Comments

@tsteckenborn
Copy link

Hi there,

It could be that the pattern defined is incorrect:

ui5-manifest/schema.json

Lines 608 to 617 in fce1a7e

"libs": {
"description": "Represents the id (namespace) of the libraries that should be loaded by UI5 Core to be used in your component",
"type": "object",
"additionalProperties": false,
"patternProperties": {
"^([a-z][a-z0-9]{0,39})(\\.[a-z][a-z0-9]{0,39})*$": {
"$ref": "#/definitions/lib"
}
}
},

It seems to support further characters, such as - and _.

So potentially the pattern should be adapted.

Best regards,
Tobias

@aleksandr-suvorov
Copy link
Contributor

Hi Tobias,

according to our tests and requirements, this regex pattern doesn't allow - and _ characters in library names. Do you have a specific library or scenario?

Best regards,
Aleksandr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants