[BUG] Consistency of resource parameters

[lechnerc77]

Is there an existing issue for this?

• I have searched the existing issues

What version of the Terraform provider are you using?

main-branch

What version of the Terraform CLI are you using?

1.7.3

What CF API version are you using?

3.153

What type of issue are you facing

bug report

Describe the bug

The parameter names of the resources are not consistent with regards to the aspect that an ID or a name should be provided especially when it comes to org and space.

Examples:

• cloudfoundry_service_instance: The parameter is called space and the ID of the CF space must be provided
• cloudfoundry_app: The parameter is called space and the name of the CF space must be provided

Expected Behavior

The fields representing IDs should be clearly distinguishable from the fields that should be provided with a name e.g., space for the name and space_id for the ID

Steps To Reproduce

Check the documentation of the above mentioned resources to check the semantic difference

Your Terraform Configuration

n/a

Roles

n/a

Add screenshots to help explain your problem

n/a

Additional context

n/a

[Gourab1998]

SInce in all other resources convention for space/org attribute means guid, we will change the app resource attribute only as space_name and org_name to make it distinct