[BUG] Inconsistent error handling for routes in App Resource

[vipinvkmenon]

Is there an existing issue for this?

• I have searched the existing issues

What version of the Terraform provider are you using?

No response

What version of the Terraform CLI are you using?

1.8.2

What CF API version are you using?

3.159.0

What type of issue are you facing

bug report

Describe the bug

When we add routes to an app resource, it overwrites errors/diagnostics thrown by other fields

Expected Behavior

Consistent behaviour. routes does not overwrite errors thrown by other fields.

Steps To Reproduce

Execute terraform apply

Your Terraform Configuration

# This resource creation will fail with error: don't know how to reflect tftypes.String into interface {}
# due to issues with params.
resource "cloudfoundry_app" "http-bin-server" {
  name         = "tf-test-do-not-delete-http-bin2"
  space_name   = "Space Name"
  org_name     = "Org Name"
  docker_image = "kennethreitz/httpbin"

service_bindings = [
    {
      service_instance : "xsuaa_svc"
      params = {
        role = "Token_Exchange"
      }
    }
  ]
 }

# -------------------------------------------

# The resource http-bin-server2
# will not fail when `routes` is present

 resource "cloudfoundry_app" "http-bin-server2" {
  name         = "tf-test-do-not-delete-http-bin3"
  space_name   = data.cloudfoundry_space.space.name
  org_name     = "PerformanceTeamBLR"
  docker_image = "kennethreitz/httpbin"

  service_bindings = [
    {
      service_instance : "xsuaa_svc"
      params = {
        role = "Token_Exchange"
      }
    }
  ]

  routes = [
    {
      route = "asdjkasss.cfapps.sap.hana.ondemand.com"
    }
  ]
 }

Roles

No response

Add screenshots to help explain your problem

No response

Additional context

Seems like in mapAppTypeToValues writes to diags instead of tempDiags.