Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Improve redaction of custom idp related values during fixture recording #277

Closed
kuntzed opened this issue Jul 5, 2023 · 1 comment · Fixed by #356
Closed

[FEATURE] Improve redaction of custom idp related values during fixture recording #277

kuntzed opened this issue Jul 5, 2023 · 1 comment · Fixed by #356
Assignees
@kuntzed
Labels
enhancement New feature or request
Milestone
0.3.0-beta1 - Aug...

Comments

@kuntzed
Copy link
Contributor

kuntzed commented Jul 5, 2023 •
edited
Loading

search for "TODO #277" in the code
@lechnerc77
Copy link
Member

Details of adjustments in provider_test.go:

  1. the custom idp and issuer values should be redacted to some special value for now the custom idp is replaced by the empty string and the issuer by "accounts.sap.com" to keep existing fixtures working that were recorded without selecting a custom idp during login.
  2. the custom idp header value should be redacted to some special value for now the header is replaced by the empty string to keep existing fixtures working that were recorded without selecting a custom idp during login

@lechnerc77 lechnerc77 added the enhancement New feature or request label Jul 14, 2023
@lechnerc77 lechnerc77 changed the title Improve redaction of custom idp related values during fixture recording [FEATURE] Improve redaction of custom idp related values during fixture recording Jul 25, 2023
kuntzed added a commit that referenced this issue Aug 1, 2023
@kuntzed
feat(testsetup): automate authentication for test fixture recording
0caa62c 
The test setup automatically detects if a fixture will be
(re-)recorded. For recording the user from env is used and
for playback a redacted test user is used.
Furthermore, re-recording can now be enforced without prior
deletion of the fixture by setting the environment variable
TEST_FORCE_REC to 'true'.

Resolves #294

Also: Improve redaction of custom idp related values by always
      using a custom idp and a test issuer.

Resolves #277
@kuntzed kuntzed mentioned this issue Aug 1, 2023
Merged
5 tasks
lechnerc77 pushed a commit that referenced this issue Aug 2, 2023
@kuntzed
feat(testsetup): automate authentication for test fixture recording (#…
3767f27 
…356)

The test setup automatically detects if a fixture will be
(re-)recorded. For recording the user from env is used and
for playback a redacted test user is used.
Furthermore, re-recording can now be enforced without prior
deletion of the fixture by setting the environment variable
TEST_FORCE_REC to 'true'.

Resolves #294

Also: Improve redaction of custom idp related values by always
      using a custom idp and a test issuer.

Resolves #277
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kuntzed kuntzed

Labels
enhancement New feature or request
Projects
None yet
Milestone
0.3.0-beta1 - August release
Development

Successfully merging a pull request may close this issue.

feat(testsetup): automate authentication for test fixture recording SAP/terraform-provider-btp
2 participants
@lechnerc77 @kuntzed