From 0be015b7360df6d36ad4f630f0096599905a6f21 Mon Sep 17 00:00:00 2001 From: Stanislav Sukhanov Date: Thu, 3 Oct 2024 10:02:54 +0200 Subject: [PATCH 1/4] fix: (CXSPA-8034) remove aria label from title dropdown * closes https://jira.tools.sap/browse/CXSPA-8034 --- .../user/profile/assets/translations/en/userProfile.json | 1 - .../user/profile/components/register/register.component.html | 3 --- .../user/profile/components/register/register.module.ts | 2 -- 3 files changed, 6 deletions(-) diff --git a/feature-libs/user/profile/assets/translations/en/userProfile.json b/feature-libs/user/profile/assets/translations/en/userProfile.json index bf0c8f8495e..aad24642d19 100644 --- a/feature-libs/user/profile/assets/translations/en/userProfile.json +++ b/feature-libs/user/profile/assets/translations/en/userProfile.json @@ -30,7 +30,6 @@ "confirmNewPassword": "Confirm New Password", "resetPassword": "Reset Password", "createAccount": "Create an account", - "title": "Title", "titleOptional": "Title (optional)", "firstName": { "label": "First name", diff --git a/feature-libs/user/profile/components/register/register.component.html b/feature-libs/user/profile/components/register/register.component.html index a2bd016fc86..9b42a88b73e 100644 --- a/feature-libs/user/profile/components/register/register.component.html +++ b/feature-libs/user/profile/components/register/register.component.html @@ -29,9 +29,6 @@ bindValue="code" formControlName="titleCode" id="title-select" - [cxNgSelectA11y]="{ - ariaLabel: 'register.title' | cxTranslate, - }" > diff --git a/feature-libs/user/profile/components/register/register.module.ts b/feature-libs/user/profile/components/register/register.module.ts index fc33bfca386..48c46454327 100644 --- a/feature-libs/user/profile/components/register/register.module.ts +++ b/feature-libs/user/profile/components/register/register.module.ts @@ -21,7 +21,6 @@ import { import { CaptchaModule, FormErrorsModule, - NgSelectA11yModule, PasswordVisibilityToggleModule, SpinnerModule, } from '@spartacus/storefront'; @@ -40,7 +39,6 @@ import { RegisterComponent } from './register.component'; SpinnerModule, FormErrorsModule, NgSelectModule, - NgSelectA11yModule, PasswordVisibilityToggleModule, FeaturesConfigModule, ], From 23d9b2d1433decbbd28484a678369d4acec9188e Mon Sep 17 00:00:00 2001 From: Stanislav Sukhanov Date: Thu, 10 Oct 2024 23:44:21 +0200 Subject: [PATCH 2/4] fix: (CXSPA-8034) remove aria label from title dropdown * closes https://jira.tools.sap/browse/CXSPA-8034 --- .../user/profile/components/register/register.component.html | 1 + .../user/profile/components/register/register.module.ts | 2 ++ 2 files changed, 3 insertions(+) diff --git a/feature-libs/user/profile/components/register/register.component.html b/feature-libs/user/profile/components/register/register.component.html index 9b42a88b73e..7cb54289b4e 100644 --- a/feature-libs/user/profile/components/register/register.component.html +++ b/feature-libs/user/profile/components/register/register.component.html @@ -29,6 +29,7 @@ bindValue="code" formControlName="titleCode" id="title-select" + cxNgSelectA11y > diff --git a/feature-libs/user/profile/components/register/register.module.ts b/feature-libs/user/profile/components/register/register.module.ts index 48c46454327..a310e15fc93 100644 --- a/feature-libs/user/profile/components/register/register.module.ts +++ b/feature-libs/user/profile/components/register/register.module.ts @@ -21,6 +21,7 @@ import { import { CaptchaModule, FormErrorsModule, + NgSelectA11yModule, PasswordVisibilityToggleModule, SpinnerModule, } from '@spartacus/storefront'; @@ -38,6 +39,7 @@ import { RegisterComponent } from './register.component'; I18nModule, SpinnerModule, FormErrorsModule, + NgSelectA11yModule, NgSelectModule, PasswordVisibilityToggleModule, FeaturesConfigModule, From b6e04343d43e0c9e5cde96fea14a690ad3fe97e5 Mon Sep 17 00:00:00 2001 From: Stanislav Sukhanov Date: Fri, 11 Oct 2024 09:55:23 +0200 Subject: [PATCH 3/4] fix: (CXSPA-8034) remove aria label from title dropdown * add ngSelectA11y directive back to the select component * set searchable property of title select to true. --- .../user/profile/components/register/register.component.html | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/feature-libs/user/profile/components/register/register.component.html b/feature-libs/user/profile/components/register/register.component.html index 7cb54289b4e..0508d7e94f0 100644 --- a/feature-libs/user/profile/components/register/register.component.html +++ b/feature-libs/user/profile/components/register/register.component.html @@ -21,10 +21,10 @@ 'register.titleOptional' | cxTranslate }} Date: Wed, 16 Oct 2024 14:38:06 +0200 Subject: [PATCH 4/4] fix: (CXSPA-8034) remove aria label from title dropdown * revert deletion of a translation key --- .../user/profile/assets/translations/en/userProfile.json | 1 + 1 file changed, 1 insertion(+) diff --git a/feature-libs/user/profile/assets/translations/en/userProfile.json b/feature-libs/user/profile/assets/translations/en/userProfile.json index aad24642d19..bf0c8f8495e 100644 --- a/feature-libs/user/profile/assets/translations/en/userProfile.json +++ b/feature-libs/user/profile/assets/translations/en/userProfile.json @@ -30,6 +30,7 @@ "confirmNewPassword": "Confirm New Password", "resetPassword": "Reset Password", "createAccount": "Create an account", + "title": "Title", "titleOptional": "Title (optional)", "firstName": { "label": "First name",