From ab71c101808658554caf10909048cd493c37a163 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Krzysztof=20Pawe=C5=82czak?= Date: Thu, 22 Jun 2023 14:29:47 +0200 Subject: [PATCH 1/2] feat: pre-fill delivery address for guest users --- .../checkout-delivery-address.component.html | 1 + .../checkout-delivery-address.component.ts | 46 ++++++++++++++++++- .../services/checkout-config.service.ts | 4 ++ .../base/root/config/checkout-config.ts | 4 ++ 4 files changed, 53 insertions(+), 2 deletions(-) diff --git a/feature-libs/checkout/base/components/checkout-delivery-address/checkout-delivery-address.component.html b/feature-libs/checkout/base/components/checkout-delivery-address/checkout-delivery-address.component.html index 383b844b7d0..f8fb7919119 100644 --- a/feature-libs/checkout/base/components/checkout-delivery-address/checkout-delivery-address.component.html +++ b/feature-libs/checkout/base/components/checkout-delivery-address/checkout-delivery-address.component.html @@ -78,6 +78,7 @@

Date: Thu, 22 Jun 2023 14:49:03 +0200 Subject: [PATCH 2/2] fix ci --- .../checkout-delivery-address.component.ts | 19 +++++++++++++------ .../services/checkout-config.service.ts | 2 +- 2 files changed, 14 insertions(+), 7 deletions(-) diff --git a/feature-libs/checkout/base/components/checkout-delivery-address/checkout-delivery-address.component.ts b/feature-libs/checkout/base/components/checkout-delivery-address/checkout-delivery-address.component.ts index 881819fe6a2..3c09d17373e 100644 --- a/feature-libs/checkout/base/components/checkout-delivery-address/checkout-delivery-address.component.ts +++ b/feature-libs/checkout/base/components/checkout-delivery-address/checkout-delivery-address.component.ts @@ -82,7 +82,9 @@ export class CheckoutDeliveryAddressComponent implements OnInit { activeCartFacade: ActiveCartFacade, checkoutStepService: CheckoutStepService, checkoutDeliveryModesFacade: CheckoutDeliveryModesFacade, - globalMessageService: GlobalMessageService + globalMessageService: GlobalMessageService, + // eslint-disable-next-line @typescript-eslint/unified-signatures + checkoutConfigService: CheckoutConfigService ); /** * @deprecated since 6.2 @@ -170,7 +172,11 @@ export class CheckoutDeliveryAddressComponent implements OnInit { } addAddress(address: Address | undefined): void { - if (!address && this.selectedAddress) { + if ( + !address && + this.shouldUseAddressSavedInCart() && + this.selectedAddress + ) { this.next(); } @@ -279,10 +285,7 @@ export class CheckoutDeliveryAddressComponent implements OnInit { this.setAddress(selected); } this.doneAutoSelect = true; - } else if ( - selected && - this.checkoutConfigService?.shouldUseAddressSavedInCart() - ) { + } else if (selected && this.shouldUseAddressSavedInCart()) { this.selectedAddress = selected; } } @@ -338,4 +341,8 @@ export class CheckoutDeliveryAddressComponent implements OnInit { protected onError(): void { this.busy$.next(false); } + + protected shouldUseAddressSavedInCart(): boolean { + return !!this.checkoutConfigService?.shouldUseAddressSavedInCart(); + } } diff --git a/feature-libs/checkout/base/components/services/checkout-config.service.ts b/feature-libs/checkout/base/components/services/checkout-config.service.ts index b260cb4485e..81fdc9f9cf2 100644 --- a/feature-libs/checkout/base/components/services/checkout-config.service.ts +++ b/feature-libs/checkout/base/components/services/checkout-config.service.ts @@ -77,7 +77,7 @@ export class CheckoutConfigService { } shouldUseAddressSavedInCart(): boolean { - return this.checkoutConfig?.checkout?.guestUseSavedAddress; + return !!this.checkoutConfig?.checkout?.guestUseSavedAddress; } getPreferredDeliveryMode(deliveryModes: DeliveryMode[]): string | undefined {