diff --git a/.github/workflows/update-cloud-repo.yml b/.github/workflows/update-cloud-repo.yml index ff547575ce9..f90f139e832 100644 --- a/.github/workflows/update-cloud-repo.yml +++ b/.github/workflows/update-cloud-repo.yml @@ -78,8 +78,17 @@ jobs: # Comment out the base url in the spartacus-configuration.module.ts file function modify_file_to_remove_baseurl() { - local file_location="../spartacus-${{ github.event.inputs.version }}-${storefront_type}/apps/spartacusstore/src/app/spartacus/spartacus-configuration.module.ts" + local path + if [ "${storefront_type}" == "b2c" ]; then + path="spartacusstore" + elif [ "${storefront_type}" == "b2b" ]; then + path="b2bspastore" + else + echo "Invalid storefront type: ${storefront_type}" + exit 1 + fi + local file_location="../spartacus-${{ github.event.inputs.version }}-${storefront_type}/apps/${path}/src/app/spartacus/spartacus-configuration.module.ts" if [ -f "${file_location}" ]; then sed -i 's/baseUrl/\/\/baseUrl/1' "${file_location}" echo "Modified ${file_location}." diff --git a/core-libs/setup/tsconfig.spec.json b/core-libs/setup/tsconfig.spec.json index 776e2a89f30..cc1fdb41f4f 100644 --- a/core-libs/setup/tsconfig.spec.json +++ b/core-libs/setup/tsconfig.spec.json @@ -353,9 +353,6 @@ "@spartacus/product-multi-dimensional/list": [ "../../feature-libs/product-multi-dimensional/list/public_api" ], - "@spartacus/product-multi-dimensional/list/occ": [ - "../../feature-libs/product-multi-dimensional/list/occ/public_api" - ], "@spartacus/product-multi-dimensional/list/root": [ "../../feature-libs/product-multi-dimensional/list/root/public_api" ], diff --git a/docs/migration/2211_19/2211-migration.md b/docs/migration/2211_19/2211-migration.md index f33fede5f5f..aec2117b81e 100644 --- a/docs/migration/2211_19/2211-migration.md +++ b/docs/migration/2211_19/2211-migration.md @@ -27,7 +27,7 @@ Follow the [Angular guidelines for upgrading from v16 to v17](https://update.ang Please also update other 3rd part dependencies from Angular ecosystem to versions compatible with Angular 17, e.g. `@ng-select/ng-select@12`, `@ngrx/store@17`, `ngx-infinite-scroll@17`: ```bash -ng update @angular/core@17 @angular/cli@17 @ng-select/ng-select@12 @ngrx/store@17 ngx-infinite-scroll@17 --force +ng update @angular/core@17 @angular/cli@17 @ng-select/ng-select@12 @ngrx/store@17 ngx-infinite-scroll@17 rxjs@7.8.1 --force git add . git commit -m "update angular 17 and 3rd party deps angular 17 compatible" ``` @@ -46,6 +46,12 @@ git add . git commit -m "add @angular-devkit/schematics@17 to dev dependencies" ``` +If `@angular-devkit/core` is not listed under the `devDependencies` in the `package.json` file, please execute the following commands: +```bash +npm i @angular-devkit/core@17 --save-dev --force +git add . +git commit -m "add @angular-devkit/core@17 to dev dependencies" +``` ### Run Spartacus update After successfully updating the application to Angular 17, execute this command to initiate the Spartacus update process. diff --git a/feature-libs/asm/tsconfig.schematics.json b/feature-libs/asm/tsconfig.schematics.json index ccc52e60bab..9f1f9485ea6 100644 --- a/feature-libs/asm/tsconfig.schematics.json +++ b/feature-libs/asm/tsconfig.schematics.json @@ -350,9 +350,6 @@ "@spartacus/product-multi-dimensional/list": [ "../../feature-libs/product-multi-dimensional/list/public_api" ], - "@spartacus/product-multi-dimensional/list/occ": [ - "../../feature-libs/product-multi-dimensional/list/occ/public_api" - ], "@spartacus/product-multi-dimensional/list/root": [ "../../feature-libs/product-multi-dimensional/list/root/public_api" ], diff --git a/feature-libs/cart/base/components/added-to-cart-dialog/added-to-cart-dialog.component.html b/feature-libs/cart/base/components/added-to-cart-dialog/added-to-cart-dialog.component.html index bf0cdb27aec..86f03af3adf 100644 --- a/feature-libs/cart/base/components/added-to-cart-dialog/added-to-cart-dialog.component.html +++ b/feature-libs/cart/base/components/added-to-cart-dialog/added-to-cart-dialog.component.html @@ -149,7 +149,22 @@