From 42ecb7c68da1dc590a60220f69c2977294bf9b25 Mon Sep 17 00:00:00 2001 From: PioBar <72926984+Pio-Bar@users.noreply.github.com> Date: Thu, 17 Oct 2024 09:50:54 +0200 Subject: [PATCH 1/9] fix: (CXSPA-927) - Search box dialog to listbox role change (#19328) --- .../navigation/search-box/search-box.component.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/projects/storefrontlib/cms-components/navigation/search-box/search-box.component.html b/projects/storefrontlib/cms-components/navigation/search-box/search-box.component.html index 54628734857..00f34cd74cc 100644 --- a/projects/storefrontlib/cms-components/navigation/search-box/search-box.component.html +++ b/projects/storefrontlib/cms-components/navigation/search-box/search-box.component.html @@ -63,7 +63,7 @@ class="results" id="results" (click)="close($any($event), true)" - role="dialog" + role="listbox" [class.no-headers]=" !isEnabledFeature(searchBoxFeatures.RECENT_SEARCHES_FEATURE) && !isEnabledFeature(searchBoxFeatures.TRENDING_SEARCHES_FEATURE) && From 313ba610cb0fddf263cc1eb95a591d699cae99ec Mon Sep 17 00:00:00 2001 From: Caine Rotherham Date: Thu, 17 Oct 2024 10:15:33 +0200 Subject: [PATCH 2/9] chore: Turn on default feature flags for a11y toggles (#19407) --- .../feature-toggles/config/feature-toggles.ts | 48 +++++++++---------- 1 file changed, 24 insertions(+), 24 deletions(-) diff --git a/projects/core/src/features-config/feature-toggles/config/feature-toggles.ts b/projects/core/src/features-config/feature-toggles/config/feature-toggles.ts index 39093d4098d..bee1088f562 100644 --- a/projects/core/src/features-config/feature-toggles/config/feature-toggles.ts +++ b/projects/core/src/features-config/feature-toggles/config/feature-toggles.ts @@ -654,37 +654,37 @@ export const defaultFeatureToggles: Required = { propagateErrorsToServer: false, ssrStrictErrorHandlingForHttpAndNgrx: false, productConfiguratorDeltaRendering: false, - a11yRequiredAsterisks: false, - a11yQuantityOrderTabbing: false, - a11yNavigationUiKeyboardControls: false, + a11yRequiredAsterisks: true, + a11yQuantityOrderTabbing: true, + a11yNavigationUiKeyboardControls: true, a11yNavMenuExpandStateReadout: false, - a11yOrderConfirmationHeadingOrder: false, - a11yStarRating: false, - a11yViewChangeAssistiveMessage: false, + a11yOrderConfirmationHeadingOrder: true, + a11yStarRating: true, + a11yViewChangeAssistiveMessage: true, a11yPreventHorizontalScroll: false, - a11yReorderDialog: false, - a11yPopoverFocus: false, - a11yScheduleReplenishment: false, - a11yScrollToTop: false, - a11ySavedCartsZoom: false, - a11ySortingOptionsTruncation: false, - a11yExpandedFocusIndicator: false, - a11yCheckoutDeliveryFocus: false, - a11yMobileVisibleFocus: false, - a11yOrganizationsBanner: false, - a11yOrganizationListHeadingOrder: false, + a11yReorderDialog: true, + a11yPopoverFocus: true, + a11yScheduleReplenishment: true, + a11yScrollToTop: true, + a11ySavedCartsZoom: true, + a11ySortingOptionsTruncation: true, + a11yExpandedFocusIndicator: true, + a11yCheckoutDeliveryFocus: true, + a11yMobileVisibleFocus: true, + a11yOrganizationsBanner: true, + a11yOrganizationListHeadingOrder: true, a11yCartImportConfirmationMessage: false, - a11yReplenishmentOrderFieldset: false, - a11yListOversizedFocus: false, - a11yStoreFinderOverflow: false, + a11yReplenishmentOrderFieldset: true, + a11yListOversizedFocus: true, + a11yStoreFinderOverflow: true, a11yMobileFocusOnFirstNavigationItem: false, - a11yCartSummaryHeadingOrder: false, + a11yCartSummaryHeadingOrder: true, a11ySearchBoxMobileFocus: false, a11yFacetKeyboardNavigation: false, - a11yUnitsListKeyboardControls: false, - a11yCartItemsLinksStyles: false, + a11yUnitsListKeyboardControls: true, + a11yCartItemsLinksStyles: true, a11yHideSelectBtnForSelectedAddrOrPayment: false, - a11yFocusableCarouselControls: false, + a11yFocusableCarouselControls: true, a11yUseTrapTabInsteadOfTrapInDialogs: false, cmsGuardsServiceUseGuardsComposer: false, cartQuickOrderRemoveListeningToFailEvent: true, From e9a1c2efef8eddb2824016021eb0da9aff5e54db Mon Sep 17 00:00:00 2001 From: Stanislav Sukhanov Date: Thu, 17 Oct 2024 10:53:38 +0200 Subject: [PATCH 3/9] fix: (CXSPA-7948) add aria-labelledby to quantity input (#19312) Co-authored-by: Miguel Estrada <15113219+developpeurweb@users.noreply.github.com> --- .../base/components/add-to-cart/add-to-cart.component.html | 3 ++- .../components/item-counter/item-counter.component.html | 1 + .../components/item-counter/item-counter.component.ts | 6 ++++++ 3 files changed, 9 insertions(+), 1 deletion(-) diff --git a/feature-libs/cart/base/components/add-to-cart/add-to-cart.component.html b/feature-libs/cart/base/components/add-to-cart/add-to-cart.component.html index cea53d5837f..489b2f32960 100644 --- a/feature-libs/cart/base/components/add-to-cart/add-to-cart.component.html +++ b/feature-libs/cart/base/components/add-to-cart/add-to-cart.component.html @@ -6,9 +6,10 @@ *ngIf="hasStock" [max]="maxQuantity" [control]="addToCartForm.get('quantity')" + [ariaDescribedById]="'add-to-card-stock-info'" > - + {{ getInventory() }} {{ hasStock diff --git a/projects/storefrontlib/shared/components/item-counter/item-counter.component.html b/projects/storefrontlib/shared/components/item-counter/item-counter.component.html index abf99b30313..6a3fd29b2a1 100644 --- a/projects/storefrontlib/shared/components/item-counter/item-counter.component.html +++ b/projects/storefrontlib/shared/components/item-counter/item-counter.component.html @@ -21,6 +21,7 @@ (keyup.enter)="updateValue()" [cxFocus]="{ key: 'qty' }" attr.aria-label="{{ 'itemCounter.quantity' | cxTranslate }}" + [attr.aria-describedby]="ariaDescribedById" />