Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSDoc issue: sap/ui/VersionInfo.load returns Promise<Object> instead of proper type description #4105

Open
heimwege opened this issue Jul 31, 2024 · 1 comment
Open

JSDoc issue: sap/ui/VersionInfo.load returns Promise<Object> instead of proper type description #4105

heimwege opened this issue Jul 31, 2024 · 1 comment
Assignees
@aborjinik @codeworrior
Labels
in progress

Comments

@heimwege
Copy link

Hey hey 👋🏻

the JSDoc of sap/ui/VersionInfo.load returns a promise of an object and thus the TypeScript type is also generated as such. Please adjust the return type so that a proper TypeScript type for sap-ui-version.json is being generated.

Thanks
Dominik
@heimwege heimwege mentioned this issue Jul 31, 2024
Merged
@codeworrior
Copy link
Member

The type Object is intentional. We don't regard the schema of sap-ui-version.json as API.

But we maybe should at least specify parts of it, leaving out internal details. I'll discuss with @petermuessig.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aborjinik aborjinik

@codeworrior codeworrior

Labels
in progress
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@aborjinik @codeworrior @heimwege