From c2186ccd9474d3626afad66149f6769bf2528963 Mon Sep 17 00:00:00 2001 From: emrecevik06 Date: Wed, 16 Oct 2024 16:36:06 +0200 Subject: [PATCH 1/5] fix: add zero state for changes panel --- .../src/panels/changes/NoChangesFound.tsx | 49 +++++++++++++++++++ 1 file changed, 49 insertions(+) create mode 100644 packages/control-property-editor/src/panels/changes/NoChangesFound.tsx diff --git a/packages/control-property-editor/src/panels/changes/NoChangesFound.tsx b/packages/control-property-editor/src/panels/changes/NoChangesFound.tsx new file mode 100644 index 0000000000..42031c7028 --- /dev/null +++ b/packages/control-property-editor/src/panels/changes/NoChangesFound.tsx @@ -0,0 +1,49 @@ +import React from 'react'; +import { Text } from '@fluentui/react'; +import { useTranslation } from 'react-i18next'; +import styles from './ChangesPanel.module.scss'; + +const NoChangesFound = () => { + const { t } = useTranslation(); + return ( + <> +
+ {t('NO_CHANGES_FOUND')} + {t('MODIFY_CHANGES')} +
+ + + + + + + + +
+
+ + ); +}; + +export { NoChangesFound }; From 5faa1cd1b39a855c05cc5ab5159286c2ee011508 Mon Sep 17 00:00:00 2001 From: emrecevik06 Date: Wed, 16 Oct 2024 16:37:31 +0200 Subject: [PATCH 2/5] add missing files --- .changeset/tasty-rocks-suffer.md | 5 + .../src/i18n/i18n.json | 179 +++++++++--------- .../panels/changes/ChangesPanel.module.scss | 22 +++ .../src/panels/changes/ChangesPanel.tsx | 3 +- .../unit/panels/changes/ChangesPanel.test.tsx | 8 +- 5 files changed, 125 insertions(+), 92 deletions(-) create mode 100644 .changeset/tasty-rocks-suffer.md diff --git a/.changeset/tasty-rocks-suffer.md b/.changeset/tasty-rocks-suffer.md new file mode 100644 index 0000000000..a113f1dce2 --- /dev/null +++ b/.changeset/tasty-rocks-suffer.md @@ -0,0 +1,5 @@ +--- +'@sap-ux/control-property-editor': patch +--- + +Add zero state for changes panel diff --git a/packages/control-property-editor/src/i18n/i18n.json b/packages/control-property-editor/src/i18n/i18n.json index 0c10cd4ac4..9ddd2abd25 100644 --- a/packages/control-property-editor/src/i18n/i18n.json +++ b/packages/control-property-editor/src/i18n/i18n.json @@ -1,91 +1,92 @@ { - "APPLICATION_PREVIEW_TITLE": "Application Preview", - "ADD_FRAGMENT_AT_EXTENSION_POINT": "Add Fragment at Extension Point", - "EXTENSION_POINT_HAS_DEFAULT_CONTENT_TEXT": "{{name}} (has default content)", - "PROPERTIES": "PROPERTIES", - "COPIED_TO_CLIPBOARD_TOAST_MESSAGE": "✓ Copied to clipboard: {{value}}", - "CONTROL_ID_LABEL": "CONTROL ID", - "CONTROL_TYPE_LABEL": "CONTROL TYPE", - "TOOL_DISCLAIMER_TITLE": "Warning", - "TOOL_DISCLAIMER_TEXT": "The Control Property Editor enables you to change control properties and behavior directly. These changes may not have the desired effect with Fiori elements applications. Please consult documentation to learn which changes are supported.", - "FE_DOCUMENTATION_LINK_TEXT": "Developing Apps with SAP Fiori Elements", - "DONT_SHOW_WARNING_ON_START": "Don't show again", - "OK": "OK", - "CANCEL": "Cancel", - "LIGHT_THEME_NAME": "Light", - "DARK_THEME_NAME": "Dark", - "HIGH_CONTRAST_THEME_NAME": "High Contrast", - "SEARCH_OUTLINE": "Filter Outline", - "NO_CONTROL_FOUND": "No control found", - "MODIFY_SEARCH_INPUT": "Modify the search input", - "APP_TITLE": "Control Property Editor", - "APP_TITLE_ADAPTATION_EDITOR": "Adaptation Editor", - "DEVICE_TYPE_DESKTOP": "Desktop", - "DEVICE_TYPE_TABLET": "Tablet", - "DEVICE_TYPE_PHONE": "Phone", - "BOOLEAN_TYPE_TRUE": "true", - "BOOLEAN_TYPE_FALSE": "false", - "ENUM_TYPE": "enumeration", - "STRING_TYPE": "string", - "INTEGER_TYPE": "integer", - "FLOAT_TYPE": "float", - "EXPRESSION_TYPE": "expression", - "ZOOM_IN": "Zoom in", - "ZOOM_OUT": "Zoom out", - "SETTINGS": "Settings", - "ICON_EDITABLE": "Editable", - "ICON_HIDDEN": "Hidden", - "FOCUS_EDITABLE": "Focus editable", - "FOCUS_COMMONLY_USED": "Show only commonly used", - "ICON_NAME": "Name", - "ICON": "Icon", - "SELECT_ICON": "Select Icon", - "NO_CONTROL_SELECTED": "No control selected", - "PROPERTIES_MODIFY_TEXT": "Select a control on the canvas to see and modify its properties", - "SEARCH_PROPERTIES": "Filter Properties", - "SHOW_EDITABLE_PROPERTIES": "Show only editable properties", - "COPIED_TO_CLIPBOARD": "Copied to clipboard", - "PROPERTY_NAME": "Property name", - "PROPERTY_TYPE": "Property type", - "DEFAULT_VALUE": "Default value", - "DEFAULT_VALUE_TOOLTIP": "This is default value set by SAP UI5 control and it may be different than the one that is used by SAP Fiori Elements. This means that after deleting all the changes for the property it's value may differ from the one displayed here.", - "CURRENT_VALUE": "Current value", - "DESCRIPTION": "Description", - "SAVED_AND_UNSAVED_CHANGES": "This {{type}} has previously saved changes and currently unsaved changes", - "UNSAVED_CHANGES": "All changes on this {{type}} are not saved", - "SAVED_CHANGES": "All changes on this {{type}} are saved", - "SAVED_VALUE": "Saved value", - "SAVE_AND_RELOAD": "Save and Reload", - "SAVE_AND_RELOAD_REQUIRED": "Changes will be visible after reload.", - "RELOAD": "Reload", - "CONFIRM_DELETE": "Delete", - "CANCEL_DELETE": "Cancel", - "DELETE_ALL_PROPERTY_CHANGES_TOOLTIP": "Delete all changes for this property", - "CONFIRM_DELETE_TITLE": "Confirm property change deletion", - "CONFIRM_OTHER_CHANGE_DELETE_TITLE": "Confirm change deletion", - "CONFIRM_DELETE_SUBTEXT": "Are you sure you want to delete all changes for this property? This action cannot be undone.", - "FIT_PREVIEW": "Fit", - "FILTER": "Filter Changes", - "CHANGE_SUMMARY_SAVED_CHANGES": "SAVED CHANGES", - "CHANGE_SUMMARY_UNSAVED_CHANGES": "UNSAVED CHANGES", - "CHANGES_DETECTED": "Changes detected!", - "CHANGES_IN_FILES": "Changes in files:", - "SHOW_CHANGES": " the app preview to show those changes.", - "CONFIRM_CHANGE_SUMMARY_DELETE_SUBTEXT": "Are you sure you want to delete the change for this property? This action cannot be undone.", - "CONFIRM_OTHER_CHANGE_DELETE_SUBTEXT": "Are you sure you want to delete this {{name}} change? This action cannot be undone.", - "NO_CONTROL_CHANGES_FOUND": "No Control Changes Found", - "CHANGE": "Change", - "FILE": "File: ", - "CONTROL": "Selector Id: ", - "MODE": "Mode", - "LIVE": "Live", - "EDIT": "Edit", - "UI_ADAPTATION": "UI Adaptation", - "SAVE": "Save", - "UNDO": "Undo", - "REDO": "Redo", - "NAVIGATION": "Navigation", - "NAVIGATE": "Navigate", - "LIST": "list", - "QUICK_ACTIONS": "{{title}} QUICK ACTIONS" + "APPLICATION_PREVIEW_TITLE": "Application Preview", + "ADD_FRAGMENT_AT_EXTENSION_POINT": "Add Fragment at Extension Point", + "EXTENSION_POINT_HAS_DEFAULT_CONTENT_TEXT": "{{name}} (has default content)", + "PROPERTIES": "PROPERTIES", + "COPIED_TO_CLIPBOARD_TOAST_MESSAGE": "✓ Copied to clipboard: {{value}}", + "CONTROL_ID_LABEL": "CONTROL ID", + "CONTROL_TYPE_LABEL": "CONTROL TYPE", + "TOOL_DISCLAIMER_TITLE": "Warning", + "TOOL_DISCLAIMER_TEXT": "The Control Property Editor enables you to change control properties and behavior directly. These changes may not have the desired effect with Fiori elements applications. Please consult documentation to learn which changes are supported.", + "FE_DOCUMENTATION_LINK_TEXT": "Developing Apps with SAP Fiori Elements", + "DONT_SHOW_WARNING_ON_START": "Don't show again", + "OK": "OK", + "CANCEL": "Cancel", + "LIGHT_THEME_NAME": "Light", + "DARK_THEME_NAME": "Dark", + "HIGH_CONTRAST_THEME_NAME": "High Contrast", + "SEARCH_OUTLINE": "Filter Outline", + "NO_CONTROL_FOUND": "No control found", + "MODIFY_SEARCH_INPUT": "Modify the search input", + "APP_TITLE": "Control Property Editor", + "APP_TITLE_ADAPTATION_EDITOR": "Adaptation Editor", + "DEVICE_TYPE_DESKTOP": "Desktop", + "DEVICE_TYPE_TABLET": "Tablet", + "DEVICE_TYPE_PHONE": "Phone", + "BOOLEAN_TYPE_TRUE": "true", + "BOOLEAN_TYPE_FALSE": "false", + "ENUM_TYPE": "enumeration", + "STRING_TYPE": "string", + "INTEGER_TYPE": "integer", + "FLOAT_TYPE": "float", + "EXPRESSION_TYPE": "expression", + "ZOOM_IN": "Zoom in", + "ZOOM_OUT": "Zoom out", + "SETTINGS": "Settings", + "ICON_EDITABLE": "Editable", + "ICON_HIDDEN": "Hidden", + "FOCUS_EDITABLE": "Focus editable", + "FOCUS_COMMONLY_USED": "Show only commonly used", + "ICON_NAME": "Name", + "ICON": "Icon", + "SELECT_ICON": "Select Icon", + "NO_CONTROL_SELECTED": "No control selected", + "PROPERTIES_MODIFY_TEXT": "Select a control on the canvas to see and modify its properties", + "SEARCH_PROPERTIES": "Filter Properties", + "SHOW_EDITABLE_PROPERTIES": "Show only editable properties", + "COPIED_TO_CLIPBOARD": "Copied to clipboard", + "PROPERTY_NAME": "Property name", + "PROPERTY_TYPE": "Property type", + "DEFAULT_VALUE": "Default value", + "DEFAULT_VALUE_TOOLTIP": "This is default value set by SAP UI5 control and it may be different than the one that is used by SAP Fiori Elements. This means that after deleting all the changes for the property it's value may differ from the one displayed here.", + "CURRENT_VALUE": "Current value", + "DESCRIPTION": "Description", + "SAVED_AND_UNSAVED_CHANGES": "This {{type}} has previously saved changes and currently unsaved changes", + "UNSAVED_CHANGES": "All changes on this {{type}} are not saved", + "SAVED_CHANGES": "All changes on this {{type}} are saved", + "SAVED_VALUE": "Saved value", + "SAVE_AND_RELOAD": "Save and Reload", + "SAVE_AND_RELOAD_REQUIRED": "Changes will be visible after reload.", + "RELOAD": "Reload", + "CONFIRM_DELETE": "Delete", + "CANCEL_DELETE": "Cancel", + "DELETE_ALL_PROPERTY_CHANGES_TOOLTIP": "Delete all changes for this property", + "CONFIRM_DELETE_TITLE": "Confirm property change deletion", + "CONFIRM_OTHER_CHANGE_DELETE_TITLE": "Confirm change deletion", + "CONFIRM_DELETE_SUBTEXT": "Are you sure you want to delete all changes for this property? This action cannot be undone.", + "FIT_PREVIEW": "Fit", + "FILTER": "Filter Changes", + "CHANGE_SUMMARY_SAVED_CHANGES": "SAVED CHANGES", + "CHANGE_SUMMARY_UNSAVED_CHANGES": "UNSAVED CHANGES", + "CHANGES_DETECTED": "Changes detected!", + "CHANGES_IN_FILES": "Changes in files:", + "SHOW_CHANGES": " the app preview to show those changes.", + "CONFIRM_CHANGE_SUMMARY_DELETE_SUBTEXT": "Are you sure you want to delete the change for this property? This action cannot be undone.", + "CONFIRM_OTHER_CHANGE_DELETE_SUBTEXT": "Are you sure you want to delete this {{name}} change? This action cannot be undone.", + "NO_CHANGES_FOUND": "No historic changes", + "MODIFY_CHANGES": "This application was not modified yet", + "CHANGE": "Change", + "FILE": "File: ", + "CONTROL": "Selector Id: ", + "MODE": "Mode", + "LIVE": "Live", + "EDIT": "Edit", + "UI_ADAPTATION": "UI Adaptation", + "SAVE": "Save", + "UNDO": "Undo", + "REDO": "Redo", + "NAVIGATION": "Navigation", + "NAVIGATE": "Navigate", + "LIST": "list", + "QUICK_ACTIONS": "{{title}} QUICK ACTIONS" } diff --git a/packages/control-property-editor/src/panels/changes/ChangesPanel.module.scss b/packages/control-property-editor/src/panels/changes/ChangesPanel.module.scss index d8835599f3..3617108483 100644 --- a/packages/control-property-editor/src/panels/changes/ChangesPanel.module.scss +++ b/packages/control-property-editor/src/panels/changes/ChangesPanel.module.scss @@ -23,3 +23,25 @@ margin-left: 15px; margin-top: 5px; } + +.noChangesFound { + font-style: normal; + font-weight: bold; + font-size: 24px; + line-height: 29px; + text-align: center; + color: var(--vscode-foreground); +} + +.modifyChanges { + font-style: normal; + font-weight: normal; + font-size: 13px; + line-height: 18px; + text-align: center; + color: var(--vscode-foreground); +} + +.historyGlockIcon { + text-align: center; +} diff --git a/packages/control-property-editor/src/panels/changes/ChangesPanel.tsx b/packages/control-property-editor/src/panels/changes/ChangesPanel.tsx index f8aeba4d2c..c6c4601796 100644 --- a/packages/control-property-editor/src/panels/changes/ChangesPanel.tsx +++ b/packages/control-property-editor/src/panels/changes/ChangesPanel.tsx @@ -18,6 +18,7 @@ import { ChangeStackHeader } from './ChangeStackHeader'; import styles from './ChangesPanel.module.scss'; import { FileChange } from './FileChange'; import { defaultFontSize } from '../properties/constants'; +import { NoChangesFound } from './NoChangesFound'; /** * React element for ChangePanel. @@ -44,7 +45,7 @@ export function ChangesPanel(): ReactElement { */ function renderChanges(): ReactElement { if (pending.length + saved.length + fileChanges.length === 0) { - return {t('NO_CONTROL_CHANGES_FOUND')}; + return ; } const fileChangesTooltip = t('CHANGES_IN_FILES') + '\n' + fileChanges.join('\n'); return ( diff --git a/packages/control-property-editor/test/unit/panels/changes/ChangesPanel.test.tsx b/packages/control-property-editor/test/unit/panels/changes/ChangesPanel.test.tsx index d872f17418..e27b2120ec 100644 --- a/packages/control-property-editor/test/unit/panels/changes/ChangesPanel.test.tsx +++ b/packages/control-property-editor/test/unit/panels/changes/ChangesPanel.test.tsx @@ -161,8 +161,12 @@ describe('ChangePanel', () => { }); // check no controls found - const noControlFound = screen.getByText(/no control changes found/i); - expect(noControlFound).toBeInTheDocument(); + const noChangesText = screen.getByText('No historic changes'); + expect(noChangesText).toHaveTextContent('No historic changes'); + const modifyApplicationText = screen.getByText('This application was not modified yet'); + expect(modifyApplicationText).toHaveTextContent('This application was not modified yet'); + const noChangesIcon = screen.getByTestId('Control-Property-Editor-No-Changes-Icon'); + expect(noChangesIcon).toBeInTheDocument(); }); test('unsaved changes - all changes', () => { From 433f547489fa5c2edb0b6fff38dcfcd08d2966da Mon Sep 17 00:00:00 2001 From: emrecevik06 Date: Wed, 16 Oct 2024 16:45:47 +0200 Subject: [PATCH 3/5] fix: indentation --- .../src/i18n/i18n.json | 180 +++++++++--------- 1 file changed, 90 insertions(+), 90 deletions(-) diff --git a/packages/control-property-editor/src/i18n/i18n.json b/packages/control-property-editor/src/i18n/i18n.json index 9ddd2abd25..643f0b6d82 100644 --- a/packages/control-property-editor/src/i18n/i18n.json +++ b/packages/control-property-editor/src/i18n/i18n.json @@ -1,92 +1,92 @@ { - "APPLICATION_PREVIEW_TITLE": "Application Preview", - "ADD_FRAGMENT_AT_EXTENSION_POINT": "Add Fragment at Extension Point", - "EXTENSION_POINT_HAS_DEFAULT_CONTENT_TEXT": "{{name}} (has default content)", - "PROPERTIES": "PROPERTIES", - "COPIED_TO_CLIPBOARD_TOAST_MESSAGE": "✓ Copied to clipboard: {{value}}", - "CONTROL_ID_LABEL": "CONTROL ID", - "CONTROL_TYPE_LABEL": "CONTROL TYPE", - "TOOL_DISCLAIMER_TITLE": "Warning", - "TOOL_DISCLAIMER_TEXT": "The Control Property Editor enables you to change control properties and behavior directly. These changes may not have the desired effect with Fiori elements applications. Please consult documentation to learn which changes are supported.", - "FE_DOCUMENTATION_LINK_TEXT": "Developing Apps with SAP Fiori Elements", - "DONT_SHOW_WARNING_ON_START": "Don't show again", - "OK": "OK", - "CANCEL": "Cancel", - "LIGHT_THEME_NAME": "Light", - "DARK_THEME_NAME": "Dark", - "HIGH_CONTRAST_THEME_NAME": "High Contrast", - "SEARCH_OUTLINE": "Filter Outline", - "NO_CONTROL_FOUND": "No control found", - "MODIFY_SEARCH_INPUT": "Modify the search input", - "APP_TITLE": "Control Property Editor", - "APP_TITLE_ADAPTATION_EDITOR": "Adaptation Editor", - "DEVICE_TYPE_DESKTOP": "Desktop", - "DEVICE_TYPE_TABLET": "Tablet", - "DEVICE_TYPE_PHONE": "Phone", - "BOOLEAN_TYPE_TRUE": "true", - "BOOLEAN_TYPE_FALSE": "false", - "ENUM_TYPE": "enumeration", - "STRING_TYPE": "string", - "INTEGER_TYPE": "integer", - "FLOAT_TYPE": "float", - "EXPRESSION_TYPE": "expression", - "ZOOM_IN": "Zoom in", - "ZOOM_OUT": "Zoom out", - "SETTINGS": "Settings", - "ICON_EDITABLE": "Editable", - "ICON_HIDDEN": "Hidden", - "FOCUS_EDITABLE": "Focus editable", - "FOCUS_COMMONLY_USED": "Show only commonly used", - "ICON_NAME": "Name", - "ICON": "Icon", - "SELECT_ICON": "Select Icon", - "NO_CONTROL_SELECTED": "No control selected", - "PROPERTIES_MODIFY_TEXT": "Select a control on the canvas to see and modify its properties", - "SEARCH_PROPERTIES": "Filter Properties", - "SHOW_EDITABLE_PROPERTIES": "Show only editable properties", - "COPIED_TO_CLIPBOARD": "Copied to clipboard", - "PROPERTY_NAME": "Property name", - "PROPERTY_TYPE": "Property type", - "DEFAULT_VALUE": "Default value", - "DEFAULT_VALUE_TOOLTIP": "This is default value set by SAP UI5 control and it may be different than the one that is used by SAP Fiori Elements. This means that after deleting all the changes for the property it's value may differ from the one displayed here.", - "CURRENT_VALUE": "Current value", - "DESCRIPTION": "Description", - "SAVED_AND_UNSAVED_CHANGES": "This {{type}} has previously saved changes and currently unsaved changes", - "UNSAVED_CHANGES": "All changes on this {{type}} are not saved", - "SAVED_CHANGES": "All changes on this {{type}} are saved", - "SAVED_VALUE": "Saved value", - "SAVE_AND_RELOAD": "Save and Reload", - "SAVE_AND_RELOAD_REQUIRED": "Changes will be visible after reload.", - "RELOAD": "Reload", - "CONFIRM_DELETE": "Delete", - "CANCEL_DELETE": "Cancel", - "DELETE_ALL_PROPERTY_CHANGES_TOOLTIP": "Delete all changes for this property", - "CONFIRM_DELETE_TITLE": "Confirm property change deletion", - "CONFIRM_OTHER_CHANGE_DELETE_TITLE": "Confirm change deletion", - "CONFIRM_DELETE_SUBTEXT": "Are you sure you want to delete all changes for this property? This action cannot be undone.", - "FIT_PREVIEW": "Fit", - "FILTER": "Filter Changes", - "CHANGE_SUMMARY_SAVED_CHANGES": "SAVED CHANGES", - "CHANGE_SUMMARY_UNSAVED_CHANGES": "UNSAVED CHANGES", - "CHANGES_DETECTED": "Changes detected!", - "CHANGES_IN_FILES": "Changes in files:", - "SHOW_CHANGES": " the app preview to show those changes.", - "CONFIRM_CHANGE_SUMMARY_DELETE_SUBTEXT": "Are you sure you want to delete the change for this property? This action cannot be undone.", - "CONFIRM_OTHER_CHANGE_DELETE_SUBTEXT": "Are you sure you want to delete this {{name}} change? This action cannot be undone.", - "NO_CHANGES_FOUND": "No historic changes", - "MODIFY_CHANGES": "This application was not modified yet", - "CHANGE": "Change", - "FILE": "File: ", - "CONTROL": "Selector Id: ", - "MODE": "Mode", - "LIVE": "Live", - "EDIT": "Edit", - "UI_ADAPTATION": "UI Adaptation", - "SAVE": "Save", - "UNDO": "Undo", - "REDO": "Redo", - "NAVIGATION": "Navigation", - "NAVIGATE": "Navigate", - "LIST": "list", - "QUICK_ACTIONS": "{{title}} QUICK ACTIONS" + "APPLICATION_PREVIEW_TITLE": "Application Preview", + "ADD_FRAGMENT_AT_EXTENSION_POINT": "Add Fragment at Extension Point", + "EXTENSION_POINT_HAS_DEFAULT_CONTENT_TEXT": "{{name}} (has default content)", + "PROPERTIES": "PROPERTIES", + "COPIED_TO_CLIPBOARD_TOAST_MESSAGE": "✓ Copied to clipboard: {{value}}", + "CONTROL_ID_LABEL": "CONTROL ID", + "CONTROL_TYPE_LABEL": "CONTROL TYPE", + "TOOL_DISCLAIMER_TITLE": "Warning", + "TOOL_DISCLAIMER_TEXT": "The Control Property Editor enables you to change control properties and behavior directly. These changes may not have the desired effect with Fiori elements applications. Please consult documentation to learn which changes are supported.", + "FE_DOCUMENTATION_LINK_TEXT": "Developing Apps with SAP Fiori Elements", + "DONT_SHOW_WARNING_ON_START": "Don't show again", + "OK": "OK", + "CANCEL": "Cancel", + "LIGHT_THEME_NAME": "Light", + "DARK_THEME_NAME": "Dark", + "HIGH_CONTRAST_THEME_NAME": "High Contrast", + "SEARCH_OUTLINE": "Filter Outline", + "NO_CONTROL_FOUND": "No control found", + "MODIFY_SEARCH_INPUT": "Modify the search input", + "APP_TITLE": "Control Property Editor", + "APP_TITLE_ADAPTATION_EDITOR": "Adaptation Editor", + "DEVICE_TYPE_DESKTOP": "Desktop", + "DEVICE_TYPE_TABLET": "Tablet", + "DEVICE_TYPE_PHONE": "Phone", + "BOOLEAN_TYPE_TRUE": "true", + "BOOLEAN_TYPE_FALSE": "false", + "ENUM_TYPE": "enumeration", + "STRING_TYPE": "string", + "INTEGER_TYPE": "integer", + "FLOAT_TYPE": "float", + "EXPRESSION_TYPE": "expression", + "ZOOM_IN": "Zoom in", + "ZOOM_OUT": "Zoom out", + "SETTINGS": "Settings", + "ICON_EDITABLE": "Editable", + "ICON_HIDDEN": "Hidden", + "FOCUS_EDITABLE": "Focus editable", + "FOCUS_COMMONLY_USED": "Show only commonly used", + "ICON_NAME": "Name", + "ICON": "Icon", + "SELECT_ICON": "Select Icon", + "NO_CONTROL_SELECTED": "No control selected", + "PROPERTIES_MODIFY_TEXT": "Select a control on the canvas to see and modify its properties", + "SEARCH_PROPERTIES": "Filter Properties", + "SHOW_EDITABLE_PROPERTIES": "Show only editable properties", + "COPIED_TO_CLIPBOARD": "Copied to clipboard", + "PROPERTY_NAME": "Property name", + "PROPERTY_TYPE": "Property type", + "DEFAULT_VALUE": "Default value", + "DEFAULT_VALUE_TOOLTIP": "This is default value set by SAP UI5 control and it may be different than the one that is used by SAP Fiori Elements. This means that after deleting all the changes for the property it's value may differ from the one displayed here.", + "CURRENT_VALUE": "Current value", + "DESCRIPTION": "Description", + "SAVED_AND_UNSAVED_CHANGES": "This {{type}} has previously saved changes and currently unsaved changes", + "UNSAVED_CHANGES": "All changes on this {{type}} are not saved", + "SAVED_CHANGES": "All changes on this {{type}} are saved", + "SAVED_VALUE": "Saved value", + "SAVE_AND_RELOAD": "Save and Reload", + "SAVE_AND_RELOAD_REQUIRED": "Changes will be visible after reload.", + "RELOAD": "Reload", + "CONFIRM_DELETE": "Delete", + "CANCEL_DELETE": "Cancel", + "DELETE_ALL_PROPERTY_CHANGES_TOOLTIP": "Delete all changes for this property", + "CONFIRM_DELETE_TITLE": "Confirm property change deletion", + "CONFIRM_OTHER_CHANGE_DELETE_TITLE": "Confirm change deletion", + "CONFIRM_DELETE_SUBTEXT": "Are you sure you want to delete all changes for this property? This action cannot be undone.", + "FIT_PREVIEW": "Fit", + "FILTER": "Filter Changes", + "CHANGE_SUMMARY_SAVED_CHANGES": "SAVED CHANGES", + "CHANGE_SUMMARY_UNSAVED_CHANGES": "UNSAVED CHANGES", + "CHANGES_DETECTED": "Changes detected!", + "CHANGES_IN_FILES": "Changes in files:", + "SHOW_CHANGES": " the app preview to show those changes.", + "CONFIRM_CHANGE_SUMMARY_DELETE_SUBTEXT": "Are you sure you want to delete the change for this property? This action cannot be undone.", + "CONFIRM_OTHER_CHANGE_DELETE_SUBTEXT": "Are you sure you want to delete this {{name}} change? This action cannot be undone.", + "NO_CHANGES_FOUND": "No historic changes", + "MODIFY_CHANGES": "This application was not modified yet", + "CHANGE": "Change", + "FILE": "File: ", + "CONTROL": "Selector Id: ", + "MODE": "Mode", + "LIVE": "Live", + "EDIT": "Edit", + "UI_ADAPTATION": "UI Adaptation", + "SAVE": "Save", + "UNDO": "Undo", + "REDO": "Redo", + "NAVIGATION": "Navigation", + "NAVIGATE": "Navigate", + "LIST": "list", + "QUICK_ACTIONS": "{{title}} QUICK ACTIONS" } From 83618937191951256ce3e687f5ffce4a853f6515 Mon Sep 17 00:00:00 2001 From: emrecevik06 Date: Wed, 16 Oct 2024 16:53:51 +0200 Subject: [PATCH 4/5] fix: remove unnecessary css class --- .../src/panels/changes/ChangesPanel.module.scss | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/packages/control-property-editor/src/panels/changes/ChangesPanel.module.scss b/packages/control-property-editor/src/panels/changes/ChangesPanel.module.scss index 3617108483..7d07052eae 100644 --- a/packages/control-property-editor/src/panels/changes/ChangesPanel.module.scss +++ b/packages/control-property-editor/src/panels/changes/ChangesPanel.module.scss @@ -8,17 +8,6 @@ border-bottom: 1px solid var(--vscode-menu-separatorBackground); } -.noData { - font-style: normal; - font-weight: bolder; - font-size: 15px; - line-height: 21px; - text-align: center; - padding-top: 20px; - margin-left: 35px; - color: var(--vscode-foreground); -} - .infoIcon { margin-left: 15px; margin-top: 5px; From e87e71c04c1d178b3333d5b45ccee82a3c1fa88c Mon Sep 17 00:00:00 2001 From: emrecevik06 Date: Wed, 16 Oct 2024 17:12:46 +0200 Subject: [PATCH 5/5] fix: lint --- .../control-property-editor/src/panels/changes/ChangesPanel.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/control-property-editor/src/panels/changes/ChangesPanel.tsx b/packages/control-property-editor/src/panels/changes/ChangesPanel.tsx index c6c4601796..a86f9e6d2d 100644 --- a/packages/control-property-editor/src/panels/changes/ChangesPanel.tsx +++ b/packages/control-property-editor/src/panels/changes/ChangesPanel.tsx @@ -4,7 +4,7 @@ import React from 'react'; import { useTranslation } from 'react-i18next'; import { useDispatch, useSelector } from 'react-redux'; -import { Text, Icon } from '@fluentui/react'; +import { Icon } from '@fluentui/react'; import { UISearchBox } from '@sap-ux/ui-components'; import type { ChangesSlice } from '../../slice';