Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE - Using minUI5Version in ADP #2444

Open
3 tasks
tobiasqueck opened this issue Oct 8, 2024 · 1 comment
Open
3 tasks

FEATURE - Using minUI5Version in ADP #2444

tobiasqueck opened this issue Oct 8, 2024 · 1 comment
Labels
adp-tooling feature New feature or request ui5-proxy-middleware @sap-ux/ui5-proxy-middleware

Comments

@tobiasqueck
Copy link
Contributor

As an ADP developer,
I want to be able to define and test with a minUI5Version,
so that I preview with the minUI5Version

Description

The UI5 proxy middleware checks the manifest.json for a minUI5Version and if it is there, uses it as preview version. This does not work for adaptation projects because there is no manifest in the project. To also support this for ADP, we also need to check the appdescr file in ADP and check if it has a minUI5Version change, and if existing, use the version.

Technical Design

What modules need to be created or enhanced?
How would the functionality be exposed and how can it be consumed?

Acceptance Criteria

GivenWhenThen format (https://martinfowler.com/bliki/GivenWhenThen.html)

Given I have a ...
when I execute ...
then ... will happen.

Notes

Tasks

  • Unit Tests added
  • Test Cases defined
@tobiasqueck tobiasqueck added feature New feature or request ui5-proxy-middleware @sap-ux/ui5-proxy-middleware adp-tooling labels Oct 8, 2024
@tobiasqueck
Copy link
Contributor Author

tobiasqueck commented Oct 8, 2024

@testojs @cfg74

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adp-tooling feature New feature or request ui5-proxy-middleware @sap-ux/ui5-proxy-middleware
Projects
None yet
Development

No branches or pull requests

1 participant