Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG - nodejs-utils: command runner should run with shell on windows #2433

Open
3 tasks
IainSAP opened this issue Oct 2, 2024 · 0 comments
Open
3 tasks

BUG - nodejs-utils: command runner should run with shell on windows #2433

IainSAP opened this issue Oct 2, 2024 · 0 comments
Assignees
Labels
bug Something isn't working nodejs-utils @sap-ux/nodejs-utils related

Comments

@IainSAP
Copy link
Contributor

IainSAP commented Oct 2, 2024

Description

Running npm -g root using the command runner here: https://github.com/SAP/open-ux-tools/blob/main/packages/nodejs-utils/src/installedCheck.ts#L112 results in undefined instead of the node_modules path expected. The additional option { shell: true } may be required on Windows platforms to run installed commands that rely on env vars such as executables added to the env path.

Steps to Reproduce

Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected results

Actual results

Screenshots

If applicable, add screenshots to help explain the problem.

Version/Components/Environment

Add any other context about the problem here
OS:

  • Mac OS
  • Windows
  • Other

Root Cause Analysis

Problem

{describe the problem}

Fix

{describe the fix}

Why was it missed

{Some explanation why this issue might have been missed during normal development/testing cycle}

How can we avoid this

{if we don’t want to see this type of issues anymore what we should do to prevent}

@IainSAP IainSAP added bug Something isn't working nodejs-utils @sap-ux/nodejs-utils related labels Oct 2, 2024
@IainSAP IainSAP self-assigned this Oct 2, 2024
@IainSAP IainSAP changed the title BUG - nodejsutils: command runner shoudl run with shell on windows BUG - nodejs-utils: command runner shoudl run with shell on windows Oct 2, 2024
IainSAP added a commit that referenced this issue Oct 3, 2024
…ell opt (#2434)

* Fix for CommandRunner not spawn child process on Windows with shell opt

#2433

* Adds cset
@IainSAP IainSAP changed the title BUG - nodejs-utils: command runner shoudl run with shell on windows BUG - nodejs-utils: command runner should run with shell on windows Oct 3, 2024
emrecevik06 pushed a commit that referenced this issue Oct 11, 2024
…ell opt (#2434)

* Fix for CommandRunner not spawn child process on Windows with shell opt

#2433

* Adds cset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working nodejs-utils @sap-ux/nodejs-utils related
Projects
None yet
Development

No branches or pull requests

1 participant