lint fixes

Author: devinea

packages/adp-tooling/src/base/helper.ts

@@ -124,24 +124,27 @@ export function filterAndMapInboundsToManifest(inbounds: Inbound[]): ManifestNam
     if (!inbounds || inbounds.length === 0) {
         return undefined;
     }
-    const filteredInbounds = inbounds.reduce((acc: { [key: string]: InboundContent }, inbound) => {
-        // Skip if hideLauncher is not false
-        if (!inbound?.content || inbound.content.hideLauncher !== false) {
-            return acc;
-        }
-        const { semanticObject, action, signature } = inbound.content;
-        if (semanticObject && action) {
-            const key = `${semanticObject}-${action}`;
-
-            // Temporary filtration of parameters to avoid issues with merged manifest until release of ABAP Platform Cloud 2508
-            if (signature?.parameters) {
-                filterIboundsParameters(signature);
+    const filteredInbounds = inbounds.reduce(
+        (acc: { [key: string]: InboundContent }, inbound) => {
+            // Skip if hideLauncher is not false
+            if (!inbound?.content || inbound.content.hideLauncher !== false) {
+                return acc;
             }
+            const { semanticObject, action, signature } = inbound.content;
+            if (semanticObject && action) {
+                const key = `${semanticObject}-${action}`;
 
-            acc[key] = inbound.content;
-        }
-        return acc;
-    }, {} as { [key: string]: InboundContent });
+                // Temporary filtration of parameters to avoid issues with merged manifest until release of ABAP Platform Cloud 2508
+                if (signature?.parameters) {
+                    filterIboundsParameters(signature);
+                }
+
+                acc[key] = inbound.content;
+            }
+            return acc;
+        },
+        {} as { [key: string]: InboundContent }
+    );
 
     return Object.keys(filteredInbounds).length === 0 ? undefined : filteredInbounds;
 }

packages/adp-tooling/test/unit/ui5/validator.test.ts

@@ -3,8 +3,7 @@ import { validateEmptyString } from '@sap-ux/project-input-validator';
 import { getOfficialBaseUI5VersionUrl, getFormattedVersion } from '../../../src/ui5/format';
 import { validateUI5VersionExists } from '../../../src';
 import { fetchMock } from '../../__mock__/global';
-import { t } from '../../../src/i18n';
-import { initI18n } from '../../../src/i18n';
+import { t, initI18n } from '../../../src/i18n';
 
 jest.mock('@sap-ux/project-input-validator', () => ({
     validateEmptyString: jest.fn()

packages/fiori-app-sub-generator/src/utils/common.ts

@@ -243,7 +243,7 @@ export async function generateLaunchConfig(
                 vscode: vscode,
                 addStartCmd,
                 sapClientParam: options.sapClientParam,
-                flpAppId: options?.enableVirtualEndpoints ? 'app-preview' : options.flpAppId ?? '',
+                flpAppId: options?.enableVirtualEndpoints ? 'app-preview' : (options.flpAppId ?? ''),
                 flpSandboxAvailable: !options?.enableVirtualEndpoints,
                 isAppStudio: isAppStudio(),
                 writeToAppOnly

packages/generator-adp/test/app.test.ts

@@ -19,9 +19,8 @@ import {
 import * as Logger from '@sap-ux/logger';
 import { isAppStudio } from '@sap-ux/btp-utils';
 import type { ToolsLogger } from '@sap-ux/logger';
-import type { Manifest } from '@sap-ux/project-access';
+import type { Manifest, ManifestNamespace } from '@sap-ux/project-access';
 import { getCredentialsFromStore } from '@sap-ux/system-access';
-import type { ManifestNamespace } from '@sap-ux/project-access';
 import { isCli, sendTelemetry } from '@sap-ux/fiori-generator-shared';
 import { type AbapServiceProvider, AdaptationProjectType } from '@sap-ux/axios-extension';
 import type { AttributesAnswers, ConfigAnswers, Language, SourceApplication, VersionDetail } from '@sap-ux/adp-tooling';

packages/store/src/data-access/filesystem.ts

@@ -150,6 +150,13 @@ class FilesystemStore<E extends object> implements DataAccess<E> {
         return Promise.resolve(entity);
     }
 
+    /**
+     *
+     * @param root0
+     * @param root0.entityName
+     * @param root0.id
+     * @param root0.entity
+     */
     public async partialUpdate({
         entityName,
         id,
@@ -173,11 +180,22 @@ class FilesystemStore<E extends object> implements DataAccess<E> {
         return this.write({ entityName, id, entity: updatedEntity });
     }
 
+    /**
+     *
+     * @param update
+     * @param existingSystem
+     */
     private mergeProperties(update: Partial<E>, existingSystem: E): E {
         const updatedEntity = { ...existingSystem, ...update };
         return { ...updatedEntity };
     }
 
+    /**
+     *
+     * @param root0
+     * @param root0.entityName
+     * @param root0.id
+     */
     async del({ entityName, id }: { entityName: string; id: string }): Promise<boolean> {
         const name = toPersistenceName(entityName);
         if (!name) {

packages/store/src/data-access/hybrid.ts

@@ -67,6 +67,12 @@ class HybridStore<E extends object> implements DataAccess<E> {
         }
     }
 
+    /**
+     *
+     * @param root0
+     * @param root0.entityName
+     * @param root0.includeSensitiveData
+     */
     public async getAll({
         entityName,
         includeSensitiveData = true
@@ -77,6 +83,12 @@ class HybridStore<E extends object> implements DataAccess<E> {
         return Object.values(await this.readAll({ entityName, includeSensitiveData })) as unknown as E[];
     }
 
+    /**
+     *
+     * @param root0
+     * @param root0.entityName
+     * @param root0.includeSensitiveData
+     */
     async readAll({
         entityName,
         includeSensitiveData = true
@@ -172,6 +184,13 @@ class HybridStore<E extends object> implements DataAccess<E> {
         return deletedinFs || deletedInSecureStore;
     }
 
+    /**
+     *
+     * @param root0
+     * @param root0.entityName
+     * @param root0.id
+     * @param root0.entity
+     */
     public async partialUpdate({
         entityName,
         id,

packages/store/src/data-provider/backend-system.ts

@@ -62,6 +62,11 @@ export const SystemDataProvider: DataProviderConstructor<BackendSystem, BackendS
         });
     }
 
+    /**
+     *
+     * @param root0
+     * @param root0.includeSensitiveData
+     */
     public async getAll({
         includeSensitiveData = true
     }: {
@@ -89,6 +94,10 @@ export const SystemDataProvider: DataProviderConstructor<BackendSystem, BackendS
         return Object.values(systems);
     }
 
+    /**
+     *
+     * @param systems
+     */
     private async ensureSystemTypesExist(systems: Record<string, BackendSystem>): Promise<boolean> {
         let allSystemsHaveType = true;
 

packages/store/src/data-provider/index.ts

@@ -23,7 +23,8 @@ export interface DataProvider<E, K extends EntityKey> {
     /**
      * Returns the data as an array related to the entity.
      *
-     * @param includeSensitiveData If true and relevant for the entity, sensitive data will be returned - defaults to true.
+     * @param options If true and relevant for the entity, sensitive data will be returned - defaults to true.
+     * @param options.includeSensitiveData If set to true, sensitive data will be included in the result.
      */
     getAll(options?: { includeSensitiveData?: boolean }): Promise<E[] | []>;
 }

packages/store/src/entities/backend-system.ts

@@ -37,6 +37,7 @@ export class BackendSystem {
      * @param root0.password
      * @param root0.userDisplayName
      * @param root0.authenticationType
+     * @param root0.systemType
      */
     constructor({
         name,

packages/store/src/services/backend-system.ts

@@ -95,6 +95,10 @@ export class SystemService implements Service<BackendSystem, BackendSystemKey> {
     public async delete(entity: BackendSystem): Promise<boolean> {
         return this.dataProvider.delete(entity);
     }
+    /**
+     *
+     * @param options
+     */
     public async getAll(options: ServiceRetrievalOptions): Promise<BackendSystem[] | []> {
         return this.dataProvider.getAll(options);
     }