fix: enable npm installation for adp cf projects

Author: nikmace

packages/generator-adp/src/app/index.ts

@@ -385,7 +385,7 @@ export default class extends Generator {
     }
 
     async install(): Promise<void> {
-        if (!this.shouldInstallDeps || this.shouldCreateExtProject || this.isCfEnv) {
+        if (!this.shouldInstallDeps || this.shouldCreateExtProject) {
             return;
         }
 
@@ -397,7 +397,7 @@ export default class extends Generator {
     }
 
     async end(): Promise<void> {
-        if (this.shouldCreateExtProject || this.isCfEnv) {
+        if (this.shouldCreateExtProject) {
             return;
         }
 
@@ -413,7 +413,7 @@ export default class extends Generator {
             });
         }
 
-        if (this.isCli) {
+        if (this.isCli || this.isCfEnv) {
             return;
         }
 
@@ -537,7 +537,7 @@ export default class extends Generator {
      * Generates the ADP project artifacts for the CF environment.
      */
     private async _generateAdpProjectArtifactsCF(): Promise<void> {
-        const projectPath = this.isMtaYamlFound ? process.cwd() : this.destinationPath();
+        const projectPath = this.destinationPath();
         const publicVersions = await fetchPublicVersions(this.logger);
 
         const manifest = this.cfPrompter.manifest;
@@ -576,6 +576,9 @@ export default class extends Generator {
      * @returns {string} The project path from the answers.
      */
     private _getProjectPath(): string {
+        if (this.isCfEnv) {
+            return join(this.destinationPath(), this.attributeAnswers.projectName);
+        }
         return join(this.attributeAnswers.targetFolder, this.attributeAnswers.projectName);
     }
 

packages/generator-adp/test/app.test.ts

@@ -642,13 +642,20 @@ describe('Adaptation Project Generator Integration Test', () => {
 
             await expect(runContext.run()).resolves.not.toThrow();
 
-            expect(executeCommandSpy).not.toHaveBeenCalled();
-            expect(sendTelemetryMock).not.toHaveBeenCalled();
-
             const generatedDirs = fs.readdirSync(cfTestOutputDir);
             expect(generatedDirs).toContain(answers.projectName);
             const projectFolder = join(cfTestOutputDir, answers.projectName);
 
+            expect(sendTelemetryMock).toHaveBeenCalledWith(
+                EventName.ADAPTATION_PROJECT_CREATED,
+                expect.objectContaining({
+                    OperatingSystem: 'testOS',
+                    Platform: 'testPlatform'
+                }),
+                projectFolder
+            );
+            expect(executeCommandSpy).not.toHaveBeenCalled();
+
             const manifestPath = join(projectFolder, 'webapp', 'manifest.appdescr_variant');
             const i18nPath = join(projectFolder, 'webapp', 'i18n', 'i18n.properties');
             const ui5Yaml = join(projectFolder, 'ui5.yaml');