Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add testing for client-support-angular #2412

Open
ndricimrr opened this issue Dec 6, 2021 · 1 comment
Open

Add testing for client-support-angular #2412

ndricimrr opened this issue Dec 6, 2021 · 1 comment
Labels
CI/CD Epic internal Stuff like NFRs, CI pipeline

Comments

@ndricimrr
Copy link
Contributor

Currently our client-support-angular package is missing tests.

Aim of the tests should be to check:
1 - That the package does not break when switching/working with different Angular versions: v11, v12, v13
2 - The intended functionality works as expected.

Investigate Task (1) and (2) and derive next steps. Task can be split in subtasks.

Potential related follow-up: #2112

@ndricimrr ndricimrr added internal Stuff like NFRs, CI pipeline CI/CD labels Dec 6, 2021
@JohannesDoberer JohannesDoberer added this to the Sprint 22 milestone Dec 7, 2021
@wdoberschuetz wdoberschuetz self-assigned this Feb 3, 2022
@wdoberschuetz
Copy link
Contributor

Here's what I think is a good way to divide this task into the following:

  1. Creating/updating a Travis so that it runs client-framework-support tests
  2. Writing unit tests where it makes sense for the client-framework-support services/components
  3. Writing integration tests that test importing of the lib and using its functions (i.e. Implement tests by using LuigiMockModule #2112)
  4. Expand Travis to include testing for three latest Angular versions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Epic internal Stuff like NFRs, CI pipeline
Projects
None yet
Development

No branches or pull requests

3 participants