-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix dependencies with security issues #4790
Conversation
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
/it-go |
@@ -118,63 +115,6 @@ func TestGetKV1Secret(t *testing.T) { | |||
}) | |||
} | |||
|
|||
func TestWriteKvSecret(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why to remove it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's not unit but integration test. And the same is tested here:
func TestVaultIntegrationWriteSecret(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* remove vault interaction from unit tests * go mod tidy * update some dependency minor versions * update github.com/getsentry/sentry-go * fix vault dependency * update google.golang.org/api and cloud.google.com/go/storage * fix unit test --------- Co-authored-by: Gulom Alimov <[email protected]>
No description provided.