karmaExecuteTests is run by default for Java CAP projects

[marikaner]

I have created a Java CAP project and this also installes node + the npm cds package. When running a the ready-made pipeline this forces me to execute karmaExecuteTests and fails because there is no karma script in the package.json (which is only there for CAP). My understanding it, that this step is executed because there is a file found that matches **/karma.conf.js. This file is located in the cds package under node_modules.

It seems to me that this is not the wanted default behavior and node_modules should be excluded by default. At least, I would like to be able to exclude the node_modules manually, but I couldn't find a proper way to do this. Instead. I now disabled the step completely - this works but it is an additional step for me and everyone else, that is hard to explain.

[o-liver]

I agree that this is not a good behaviour. It seems to be defined here. Where this is used exactly, I don't know. Would it maybe be possible to exclude the node_modules dir in the pattern directly?

[henri-kohlberg]

Stumbled across the same issue multiple times in various pipelines. The theory regarding the node_modules folder seems plausible to me. My workaround is to simply disable the karma test execution in every new pipeline I create even without checking whether this step is executed, I just had this issue too many times.

[github-actions]

Thank you for your contribution! This issue is stale because it has been open 60 days with no activity. In order to keep it open, please remove stale label or add a comment within the next 10 days. If you need a Piper team member to remove the stale label make sure to add @SAP/jenkins-library-team to your comment.

[henri-kohlberg]

I agree that this is not a good behaviour. It seems to be defined here. Where this is used exactly, I don't know. Would it maybe be possible to exclude the node_modules dir in the pattern directly?

Depending on which glob patterns are supported at this place this could easily be fixed with !node_modules/**/karma.conf.js, see Glob Tool [digitalocean.com]

[github-actions]

Thank you for your contribution! This issue is stale because it has been open 60 days with no activity. In order to keep it open, please remove stale label or add a comment within the next 10 days. If you need a Piper team member to remove the stale label make sure to add @SAP/jenkins-library-team to your comment.

[github-actions]

Issue got stale and no further activity happened. It has automatically been closed. Please re-open in case you still consider it relevant.