Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK init will be failed if network off, and developer won't know #88

Open
3 tasks done
ajunjunandtmac opened this issue Oct 10, 2024 · 0 comments
Open
3 tasks done
Labels
bug Something isn't working

Comments

@ajunjunandtmac
Copy link

Checklist

  • The issue can be reproduced in the attached sample application in the repository.
  • I have read the relevant SDK documentation and have not found a suitable solution or answer.
  • I agree to the terms within the SAP Code of Conduct.

Description

When calling the public func initFor(apiKey: String, apiDomain: String? = nil, cname: String? = nil) method without network,
businessApiService.apiService.getSDKConfig() will fail, but the developer won't know that SDK init has failed.
If the portal enables the TFA function, then user calls the login method.
SDK will report error '409038 Missing deviceId When making a REST request that requires RBA and the request does not include a deviceId in the clientContext property'.

Reproduction

  • Enable TFA in portal
  • turn off phone's network
  • launch demo app
  • login will be failed

Additional context

No response

SDK version

1.6.3 and 1.7.0 all tested

@ajunjunandtmac ajunjunandtmac added the bug Something isn't working label Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant