Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deployment_target in Gigya.podspec and GigyaTfa.podspec are different, cause a compiling error #81

Open
3 tasks done
ajunjunandtmac opened this issue Apr 21, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@ajunjunandtmac
Copy link

Checklist

  • The issue can be reproduced in the attached sample application in the repository.
  • I have read the relevant SDK documentation and have not found a suitable solution or answer.
  • I agree to the terms within the SAP Code of Conduct.

Description

when i use Gigya 1.6.0 and GigyaTfa 1.0.14 at the same time, a compiling error will occur
Please see the error message below
/Users/xxx/Documents/xxx/Commercial/xxx/xxx_ios/Pods/GigyaTfa/GigyaTfa/GigyaTfa/GigyaTfa.swift:10:8 Compiling for iOS 10.0, but module 'Gigya' has a minimum deployment target of iOS 11.0:

Reproduction

pod 'Gigya', '1.6.0'
pod 'GigyaTfa', '1.0.14'
Pod install
Then build the project

Additional context

No response

SDK version

'Gigya', '1.6.0' and 'GigyaTfa', '1.0.14'

@ajunjunandtmac ajunjunandtmac added the bug Something isn't working label Apr 21, 2024
@sagishm
Copy link
Member

sagishm commented Apr 21, 2024

Workaround: go to the Pods project -> GigyaTfa -> change minimum iOS to 11.

@ajunjunandtmac
Copy link
Author

ajunjunandtmac commented Apr 21, 2024

Workaround: go to the Pods project -> GigyaTfa -> change minimum iOS to 11.

Thanks for your reply, i know that, but we build our ipa file with pipeline in a remote machine and we ignore the pod directory right now

i temporary use this script to solve the problem

  installer.pods_project.targets.each do |target|
      if target.name == 'GigyaTfa'
          target.build_configurations.each do |config|
              config.build_settings['IPHONEOS_DEPLOYMENT_TARGET'] = '11.0'
          end
      end
  end

I wonder can you fix this by modifying the pod spec in the next version or is there some special scenario you must do that? because i just want to get an official support. thanks again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants