Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppName with spaces not supported by gigya-swift-sdk SDK #72

Open
3 tasks done
alejoberman opened this issue Feb 7, 2024 · 0 comments
Open
3 tasks done

AppName with spaces not supported by gigya-swift-sdk SDK #72

alejoberman opened this issue Feb 7, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@alejoberman
Copy link

Checklist

  • The issue can be reproduced in the attached sample application in the repository.
  • I have read the relevant SDK documentation and have not found a suitable solution or answer.
  • I agree to the terms within the SAP Code of Conduct.

Description

Unsupported applications with spaces into CFBundleName by gigya-swift-sdk SDK

I propose a fix to allow AppName with spaces according to Xcode rules (@see conversions on Project Builds settings from Product Name or target name to Product Module Name

You can find a proposed fix in the attached patch file

allows_appName_with_spaces_into_CFBundleName.patch

Reproduction

1 - Implements a Social Wrapper conforms to ProviderWrapperProtocol for example GoogleWrapper
2 - Configure your application name with space example target = "My App" or Product Name = "My App"
3 - Try to launch a social login with Google.
4 - The SDK calls a fatalError

Additional context

No response

SDK version

All versions

@alejoberman alejoberman added the bug Something isn't working label Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant