Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisit JWKS Cache logic #1241

Closed
liga-oz opened this issue Jul 21, 2023 · 1 comment
Closed

Revisit JWKS Cache logic #1241

liga-oz opened this issue Jul 21, 2023 · 1 comment

Comments

@liga-oz
Copy link
Contributor

liga-oz commented Jul 21, 2023 •
edited
Loading

Potential suggestion:
keySet == null || !keySet.containsAppTid(appTid) **_|| keySet.getAll().isEmpty()_**
This will refresh empty JWKS instead of logging the error in line 175 for the whole cache duration and returning null. It means more load on XSUAA though when it returns empty JWKS.

Originally posted by @finkmanAtSap in #1238 (comment)

https://github.com/SAP/cloud-security-services-integration-library/pull/1237/files#r1269076951
@liga-oz liga-oz mentioned this issue Jul 21, 2023
Merged
@finkmanAtSap
Copy link
Contributor

Closing this as Github Issue section is no longer maintained.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@liga-oz @finkmanAtSap