Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: Rename the ServiceBindingAccessor #44

Open
Johannes-Schneider opened this issue Aug 11, 2022 · 0 comments
Open

Refactor: Rename the ServiceBindingAccessor #44

Johannes-Schneider opened this issue Aug 11, 2022 · 0 comments
Labels
breaking This issue needs breaking changes enhancement New feature or request

Comments

@Johannes-Schneider
Copy link
Contributor

Context

The term Accessor might be a bit confusing, especially in combination with the SAP Cloud SDK where the term Accessor has a very different semantic.

Request

Consider renaming the ServiceBindingAccessor interface (along with all implementations) to not confuse consumers of both libraries (the BTP Environment Variable Access library and the SAP Cloud SDK) with the different semantics.

Suggestions

Consider following names:

  • ServiceBindingLoader
  • ServiceBindingSource
@Johannes-Schneider Johannes-Schneider added enhancement New feature or request breaking This issue needs breaking changes labels Aug 11, 2022
@Johannes-Schneider Johannes-Schneider mentioned this issue Aug 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking This issue needs breaking changes enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Johannes-Schneider