Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing parking fields in land use file #10

Open
JiaXu1024 opened this issue Nov 26, 2024 · 9 comments
Open

missing parking fields in land use file #10

JiaXu1024 opened this issue Nov 26, 2024 · 9 comments
Assignees
Labels
bug Something isn't working

Comments

@JiaXu1024
Copy link
Contributor

JiaXu1024 commented Nov 26, 2024

The following attributes are missing in the output SR15 land use file:

  • exp_hourly
  • exp_daily
  • exp_monthly
  • parking_type
  • parking_spaces

The above attributes are generated from land use prep tool to SR15 land use file:
https://github.com/SANDAG/landuse_prep_tool/blob/main/2_ABM_Preprocess/run_preprocess.py#L78-L169

parking_type: https://github.com/SANDAG/landuse_prep_tool/blob/main/1_1_Parking/3_costs_estimation/estimate_parking_costs.py#L12-L130
expected parking cost: https://github.com/SANDAG/landuse_prep_tool/blob/main/1_1_Parking/3_costs_estimation/estimate_parking_costs.py#L203-L223

How do we get the missing parking attributes from SR14 land use file? In SR 14 land use file, we had parking cost (hourly, daily and monthly).

@JiaXu1024 JiaXu1024 added the bug Something isn't working label Nov 26, 2024
@jfdman
Copy link

jfdman commented Nov 26, 2024

Hi Susan, I dont think we want to copy these attributes from SR14 data. We want to use the SR15 values, since the purpose of converting the data is to test just the changes in population and employment on ABM3 while keeping all other inputs constant.

@ednaaguilar
Copy link
Contributor

Hi Susan, I pushed the latest file conversion script to the 2-script-to-convert-SR14-land-use-files branch

@JiaXu1024
Copy link
Contributor Author

Hi Susan, I pushed the latest file conversion script to the 2-script-to-convert-SR14-land-use-files branch

Hi Edna, I have tested the updated scripts and generated new land use files that were used for a new model run. The model run failed due to memory issue:
image
Then I checked parking attributes in land use file and I found there are 2694 MGRAs with parking type 0 in converted SR15 parking. Could you investigate more about why parking type has values of 0?

@ednaaguilar
Copy link
Contributor

ednaaguilar commented Jan 6, 2025

Hi Susan - good catch. The parking types were zero due to an incorrectly specified join/merge. I pushed the latest update to the branch. There should be no mgra with parking_type == 0.

@JiaXu1024
Copy link
Contributor Author

Hi Susan - good catch. The parking types were zero due to an incorrectly specified join/merge. I pushed the latest update to the branch. There should be no mgra with parking_type == 0.

Hi Edna, thanks for fixing the issue of parking_type values.

@JiaXu1024
Copy link
Contributor Author

The converted land use file now has 7155 MGRAs with parking type 1. Comparing the current sr15 land use file which has 2362 parking type 1 MGRAs, I wonder if we need to run parking location on subset of area to avoid out of memory issue? @ednaaguilar @jfdman

@aletzdy
Copy link

aletzdy commented Jan 13, 2025

@JiaXu1024 there are two changes required to limit parking location choice model to only run on a subset area (CBD as we discussed). The first change modifies the trips that will be processed by this model , and the second change modifies the definition of zones that will be eligible as alternatives in this model:

First, in parking location choice preprocessor, the term land_use.parking_type needs to be replaced by land_use.pseudomsa.

The second place is in the annotate_landuse, where we need to change the definition of is_parking_zone from land_use.parking_type == 1 to land_use.pseudomsa== 1

@JiaXu1024
Copy link
Contributor Author

@JiaXu1024 there are two changes required to limit parking location choice model to only run on a subset area (CBD as we discussed). The first change modifies the trips that will be processed by this model , and the second change modifies the definition of zones that will be eligible as alternatives in this model:

First, in parking location choice preprocessor, the term land_use.parking_type needs to be replaced by land_use.pseudomsa.

The second place is in the annotate_landuse, where we need to change the definition of is_parking_zone from land_use.parking_type == 1 to land_use.pseudomsa== 1

Hi Ali, thanks for helping with the required changes to make the parking location model for CBD area only. I wonder the 2nd change in the annotate_landuse, currently it is land_use.parking_type >0 , is it correct?

@aletzdy
Copy link

aletzdy commented Jan 14, 2025

I had pointed to the wrong annotate land use in the hyperlink, sorry. The land use I pointed to is from the estimation folder, which is outdated. Please look at the one in the resident folder that the model actually uses.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants