Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ord argument not used for any instrument #53

Open
hematthi opened this issue May 22, 2022 · 0 comments
Open

ord argument not used for any instrument #53

hematthi opened this issue May 22, 2022 · 0 comments
Labels
question Further information is requested

Comments

@hematthi
Copy link
Collaborator

#max_col_default(::NEID2D, ord::Integer) = 8429 # DRS 0.5
#max_col_default(::NEID2D, ord::Integer) = 6214 # DRS 0.6, avoiding NaN in col 6215
#max_col_default(::NEID2D, ord::Integer) = 9215 # DRS 0.6, 0.7
min_col_default(::NEID2D, ord::Integer) = 1500 # Avoid where continuum normalization effected by edges/scattered light
max_col_default(::NEID2D, ord::Integer) = 8000 # Avoid where continuum normalization effected by edges/scattered light
import RvSpectMLBase: get_pixel_range
function get_pixel_range(inst::NEID2D, ord::Integer)
minc = max(min_col_default(inst, ord)) #, min_col_excalibur(inst,order), min_col_nonnan(inst,order))
maxc = min(max_col_default(inst, ord)) #, max_col_excalibur(inst,order), max_col_nonnan(inst,order))
return minc:maxc
end

Any reason why ord is a required argument for these functions even though the col numbers do not depend on order (this appears true for all the instruments)? Is this simply in anticipation for when it might be order dependent in the future?

@hematthi hematthi changed the title ord argument not required for any instrument ord argument not used for any instrument May 22, 2022
@hematthi hematthi added the question Further information is requested label May 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant