Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up old/commented code #48

Open
hematthi opened this issue May 21, 2022 · 0 comments
Open

clean up old/commented code #48

hematthi opened this issue May 21, 2022 · 0 comments
Labels
documentation Improvements or additions to documentation

Comments

@hematthi
Copy link
Collaborator

"""Create Dataframe containing filenames and key data for all files neid*.fits in directory"""
function make_manifest(data_path::String ; max_spectra_to_use::Int = 1000 )
df_filenames = EchelleInstruments.make_manifest(data_path,r"^neidL[1,2]_\d+[T\.]\d+\.fits$")
#=
dir_filelist = readdir(data_path,join=true)
idx_spectra = map(fn->occursin(r"^neidL1_\d+[T\.]\d+\.fits$", last(split(fn,'/')) ),dir_filelist)
spectra_filelist = dir_filelist[idx_spectra]
=#
#=
df_files = DataFrame(Filename = String[], target = String[], bjd = Float64[], ssbz=Float64[] )
map(fn->add_metadata_from_fits!(df_files,fn),spectra_filelist)
df_files
=#
#@assert length(spectra_filelist) >= 1
#df_files = DataFrame(read_metadata(spectra_filelist[1]))
df_files = DataFrame(read_metadata(df_filenames.Filename[1]))
keys = propertynames(df_files)
allowmissing!(df_files, keys[map(k->k[:Filename, :bjd, :target, :airmass],keys)] )
#println("df_files = ", df_files)
#if length(spectra_filelist) >= 2
if length(df_filenames.Filename) >= 2
max_idx = min(max_spectra_to_use,length(df_filenames.Filename))
map(fn->add_metadata_from_fits!(df_files,fn),df_filenames.Filename[2:max_idx])
end
#=
for i in 2:length(spectra_filelist)
try
add_metadata_from_fits!(df_files,spectra_filelist[i])
catch
println("# Problem reading ", spectra_filelist[i])
fields_to_save = metadata_symbols_default(NEID2D())
fields_str_to_save = metadata_strings_default(NEID2D())
metadata_tmp = read_metadata_from_fits(spectra_filelist[i],fields=fields_to_save,fields_str=fields_str_to_save)
println("Before: ", metadata_tmp)
#println("After : ", metadata_tmp)
#push!(df_files,metadata_tmp)
end
end
=#
df_files
end

@hematthi hematthi added the documentation Improvements or additions to documentation label May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

1 participant