Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

naming consistency with default_filter_line_list_λmin or default_λmin #42

Open
hematthi opened this issue May 20, 2022 · 0 comments
Open
Labels
enhancement New feature or request

Comments

@hematthi
Copy link
Collaborator

default_filter_line_list_λmin = 4738.0 # Based on HD 101501, should generalize
default_filter_line_list_λmax = 7227.0 #

Is there a reason this is named default_filter_line_list_λmin instead of just default_λmin like for all of the other instruments? (And likewise for _λmax)
Could be made consistent; also update the following if renamed:

function filter_line_list(df::DataFrame, inst::IT ;
λmin::Real = default_filter_line_list_λmin, λmax::Real = default_filter_line_list_λmax ) where {
IT<:EXPRES.AnyEXPRES }

@hematthi hematthi added the enhancement New feature or request label May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant