Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dict :Filename may store a FITS type #39

Open
hematthi opened this issue May 20, 2022 · 1 comment
Open

dict :Filename may store a FITS type #39

hematthi opened this issue May 20, 2022 · 1 comment
Labels
question Further information is requested

Comments

@hematthi
Copy link
Collaborator

EchelleInstruments.jl/src/harps-n/io.jl

Line 49 in 98d5a94

dict[:Filename] = fn

Is this OK if fn is a FITS type? The equivalent function read_metadata for EXPRES passes an additional argument filename (string) just for this field.
@hematthi
Copy link
Collaborator Author

Same issue for harps:

EchelleInstruments.jl/src/harps/io.jl

Line 41 in 98d5a94

dict[:Filename] = fn

@hematthi hematthi added the question Further information is requested label May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hematthi