New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

`smooth_length` argument not used in function #32

Open

hematthi opened this issue May 19, 2022 · 0 comments

Labels

Collaborator

hematthi commented May 19, 2022

EchelleInstruments.jl/src/expres/io.jl

Lines 104 to 107 in 98d5a94

    
           function smooth_blaze(x::AbstractArray{T1,1}; degree::Integer = default_smooth_blaze_degree, smooth_length::Integer = default_smooth_blaze_length) where { T1 <: Real } 
        
               poly = Polynomials.fit(1:length(x),x,degree,weights=max.(zero(x),x) ) 
        
               poly.(collect(range(1.0,length=length(x)))) 
        
           end

Also documentation would be nice

hematthi added the help wanted label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment