Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Bitstream Filter functionality #222

Closed
tobyspark opened this issue Sep 6, 2022 · 6 comments
Closed

Expose Bitstream Filter functionality #222

tobyspark opened this issue Sep 6, 2022 · 6 comments

Comments

@tobyspark
Copy link

Feature request – expose Bitstream Filter functionality, e.g. bsf.c. This allows modification of AVPackets, to e.g. set H264 metadata.

ps. This is a heroic project. Thanks for all the work that must have gone into it.

pps. If I have missed something, or you can give me some hints on what I’d need to do to enable this myself as a contribution, please let me know.

@Ruslan-B
Copy link
Owner

Ruslan-B commented Sep 6, 2022

Thank you. It will be a part of new API witch will break thing or two #217
Need a time to finalize. Will push new update in few days.
With respect to contribution PR's are welcome it easy to setup VS 2022 but I am conservative to accept them as there are reasons.
This repo and package is bare bone - C to C#.

@tobyspark
Copy link
Author

Thanks for the reply. The “bare bones C to C#” is what attracted me! (Though that’s also the surprise behind this request, as I couldn’t recreate a C example.)

@Ruslan-B
Copy link
Owner

Ruslan-B commented Sep 8, 2022

Could you please specify what types you are missing now as I started to look and seems everything is included starting from 4.4 I think.

@Ruslan-B
Copy link
Owner

Ruslan-B commented Sep 8, 2022

If it is in bsf_internal.h - then it is not a part official API.

@tobyspark
Copy link
Author

I don’t think it’s private, as bsf.h doesn’t have “internal” or “avpriv” or any of the other markers I’ve seen.

That said, a) generally I find the FFmpeg codebase and how to use it quite confusing so shrug and b) I no longer need this, in no small part because I’ve realised some of the metadata I wanted to set was already there, just most PC browsers seem to ignore it.

I’ll close this now as I suspect both of us have more important things to do, and anyone who was in my position will at least find this issue. Thank you again for your efforts.

@Ruslan-B
Copy link
Owner

Ruslan-B commented Sep 9, 2022

@tobyspark submit bug to FFmpeg then. Right now you can port some structs by hand or generate private version of this repo with extras includes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants