Activity: 7.12.13 ActiveCode (ch8Ex7q)

[lryderWHS]

Please check the current issues Many bug reports are duplicates, this just creates more work for us. Searching the issues first may give you your answer or a workaround! If not adding new information to an existing report is much more helpful than a new report.

What Course are you in
CSAwesome

What Page were you on
7.12. Code Practice with ArrayLists
Activity: 7.12.13 ActiveCode (ch8Ex7q)

What is your username
[email protected]

Describe the bug
The activity requires implementation of this method
public static void removeLongStrings(ArrayList list)

The error reported by the test is:
./RunestoneTests.java:16: error: method removeLongStrings in class Test1 cannot be applied to given types;
Test1.removeLongStrings(values, maxLength);
^
required: ArrayList
found: ArrayList,int
reason: actual and formal argument lists differ in length

Which seems to imply that the tester is calling the method with 2 arguments instead 1.

[bhoffman0]

I am not able to reproduce this error. I think there may be an error in your own code. Please try this code.
public static void removeLongStrings(ArrayList list)
{
int count = 0;
while (count < list.size())
{
if (list.get(count).length() > 4)
{
list.remove(count);
}
count++;
}
}
This passes all the unit tests for me.

[lryderWHS]

[cid:8076e900-a62a-448d-aa0f-2380202dcdd1] I still get the same error. Also I believe your suggested code on line 14 should be: else count++; (but this isn't causing the compile error) Lisa Ryder Mathematics and Computer Science [cid:8d785ea4-ac45-4537-a921-adcb29334329]

…

________________________________ From: Beryl Hoffman ***@***.***> Sent: Wednesday, January 31, 2024 5:15 PM To: RunestoneInteractive/rs ***@***.***> Cc: Lisa Ryder ***@***.***>; Author ***@***.***> Subject: Re: [RunestoneInteractive/rs] Activity: 7.12.13 ActiveCode (ch8Ex7q) (Issue #467) You don't often get email from ***@***.*** Learn why this is important<https://aka.ms/LearnAboutSenderIdentification> CAUTION: This email is from an external sender. If this message looks suspicious, please report the message<https://conejousd.sharepoint.com/sites/TSKB/SitePages/Reporting-Email.aspx>. I am not able to reproduce this error. I think there may be an error in your own code. Please try this code. public static void removeLongStrings(ArrayList list) { int count = 0; while (count < list.size()) { if (list.get(count).length() > 4) { list.remove(count); } count++; } } This passes all the unit tests for me. — Reply to this email directly, view it on GitHub<#467 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BFOMI5EPCNEZHV5GQUUTY5TYRLUEVAVCNFSM6AAAAABCTRLNEKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRQGI4TMMBRGE>. You are receiving this because you authored the thread.Message ID: ***@***.***>

[bhoffman0]

Could you send the code that you are using and a screenshot of the compile erorrs? If you go back to the first run and run it with no code added, do you still get compile errors? I get no compile errors although the tests fail.

[lryderWHS]

[lryderWHS]

[lryderWHS]

My thought is the compile error is coming from a unit test in a file called RunestoneTests that is calling the method on line 16 with 2 arguments, instead of one.

[gigamonkey]

You can see the tests if you view source on the page. When I do that on https://runestone.academy/ns/books/published/csawesome/Unit7-ArrayList/listPractice.html?mode=browsing

I see this test code starting at line 1484:

import static org.junit.Assert.*;

import org.junit.*;

import java.io.*;
import java.util.ArrayList;

public class RunestoneTests extends CodeTestHelper
{
    @Test
    public void testMain() throws IOException
    {
        String output = getMethodOutput("main");
        String expect =
                "Expected Result:\t [fish, cat, foo]\n" + "Your Result:\t\t [fish, cat, foo]\n";
        boolean passed = getResults(expect, output, "Expected output from main");
        assertTrue(passed);
    }

    @Test
    public void testRemoveLongStrings()
    {
        ArrayList<String> mylist1 = new ArrayList<String>();
        mylist1.add("longword");
        mylist1.add("dog");
        mylist1.add("longword");
        mylist1.add("wee");

        ArrayList<String> mylist2 = new ArrayList<>();
        mylist2.add("dog");
        mylist2.add("wee");

        Test1.removeLongStrings(mylist1);

        boolean result = mylist2.equals(mylist1);

        boolean passed = getResults("true", "" + result, "removeLongStrings method test");
        assertTrue(passed);
    }
}

What do you see?

[gigamonkey]

Also, what's the URL of your CSAwesome. It feels like you somehow have a different version than the latest?

[lryderWHS]

I have two classes:

https://runestone.academy/ns/books/published/westlakehighschool_2023_Period2/index.html

https://runestone.academy/ns/books/published/westlakehighschool_2023_Period5/index.html

and I use this one for myself:
https://runestone.academy/ns/books/published/csawesome/index.html

[lryderWHS]

This is the URL where I am experiencing the issue

https://runestone.academy/ns/books/published/csawesome/Unit7-ArrayList/listPractice.html

[bhoffman0]

Thanks, but this is a mystery! I am not seeing that behavior. The tests do not have that error-producing code, see line 724 in https://github.com/bhoffman0/CSAwesome/blob/master/_sources/Unit7-ArrayList/listPractice.rst?plain=1. I'm thinking that this is an error in a particular server which is perhaps compiling the wrong Java code. @bnmnetp is it possible to clear the cache for Java files like you do periodically on server2?
Could you please do CTRL-Shift-j and scroll up to the top of the console messages to see which server you are on?
Could you also do right click and select View Page Source as Peter suggested and look at line 1502 to see if you have Test1.removeLongStrings(mylist1); or something else there?

[lryderWHS]

[lryderWHS]

When I view source code I see the correct code on line 1502

[gigamonkey]

[Edit: oh, whoops. Beryl already asked you about this. Sorry.]

Okay, next debugging step: can you open the developer tools and scroll to the top of the console where the first line should be something like:

This page served by server5

What does it say for you? It's possible that some server has a cached version of the compiled tests that's wildly out of date or something.

[lryderWHS]

This page served by server2

[bnmnetp]

@bhoffman0 I have a cron job that cleans the cache on all of the jobe servers every day, removing files more than 4 days old.

The server you are assigned is based on the IP address of your computer, so @lryderWHS would get the same server and JOBE server regardless of the course.

Now, on server 2 if I check the cache of files I do see various definitions of the removeLongStrings function with and without the second parameter sometimes called maxLength, toMaxLength, m, or x ...

These files are dated january 27 or newer.

No files like that are found on server3...

[bnmnetp]

@bhoffman0 where could the different versions of that code be coming from? The test code is not editable by the user, unless these are variations that have been created by instructors in the web interface?

[bhoffman0]

I'm on server1 and Peter is on server5 and we created some removeLongStrings functions with 2 args to try to get the same error without success, but not on server2 and just in the student code area, not in the unit test code. I checked the question bank in assignments for 7.12 and there were no copies of any exercises in that lesson and nothing with that name or function in the exercises lesson.

[bhoffman0]

@bnmnetp maybe delete the files with removeLongStrings on server2 and see if the problem goes away?

[bnmnetp]

I thought of that, but I was hoping we could get to the bottom of why this happened before I make the problem vanish.

[bhoffman0]

yeah all I could think of was the weird cache problem.

[bnmnetp]

There are 3 questions in the database that call Test1.removeLongStrings. None of them have the second parameter.

Two of the cached files have the second parameter:
stoneca280cb55e51c1918966cbd243dfd8a2

import java.util.ArrayList;

public class RunestoneTests {
    public static void main(String[] args) {
        // instantiate ArrayList and fill with Strings
        ArrayList<String> values = new ArrayList<String>();
        String[] words = {"bathtub", "fish", "computer", "cat", "foo"};
        for (int i = 0; i < words.length; i++) {
            values.add(words[i]);
        }

        // Specify the maximum length of strings to keep (e.g., 6 in this case)
        int maxLength = 6;

        // Call removeLongStrings with both arguments
        Test1.removeLongStrings(values, maxLength);

        System.out.println("Expected Result:\t [fish, cat, foo]");
        System.out.println("Your Result:\t\t " + values);
    }
}

and stonecf111f2de0694dbce8df108ecddb5f32

import java.util.ArrayList;

public class Test1
{
    public static void removeLongStrings(ArrayList<String> list)
    {
        // code here
    }

    public static void main(String[] args)
    {
        // instantiate ArrayList and fill with Integers
        ArrayList<String> values = new ArrayList<String>();
        String[] words = {"bathtub", "fish", "computer", "cat", "foo"};
        for (int i = 0; i < words.length; i++)
        {
            values.add(words[i]);
        }
        Test1.removeLongStrings(values, words.length);
        System.out.println("Expected Result:\t [fish, cat, foo]");
        System.out.println("Your Result:\t\t " + values);
    }
}

And timestamps:

root@e5537f499757:/home/jobe/files/ru/ne# ls -l stonecf111f2de0694dbce8df108ecddb5f32
-rw-r--r-- 1 www-data www-data 735 Jan 27 14:07 stonecf111f2de0694dbce8df108ecddb5f32
root@e5537f499757:/home/jobe/files/ru/ne# ls -l stoneca280cb55e51c1918966cbd243dfd8a2
-rw-r--r-- 1 www-data www-data 677 Jan 30 14:27 stoneca280cb55e51c1918966cbd243dfd8a2
root@e5537f499757:/home/jobe/files/ru/ne# more stoneca280cb55e51c1918966cbd243dfd8a2        

[bnmnetp]

With that, I have now removed those two files from the cache on server2. @lryderWHS hopefully that solves your problem.

[bnmnetp]

Was the removal of the second parameter a change that @bhoffman0 or @gigamonkey made recently? A change you recall from the distant past?

[bhoffman0]

No, I looked at git blame and that problem hasn't been touched in 4 years, other than the reformatter 7 months ago which only changed spacing. (line 724 in https://github.com/bhoffman0/CSAwesome/blame/master/_sources/Unit7-ArrayList/listPractice.rst).
Maybe it got confused because someone renamed their class RunestoneTests in that first cached file.

[lryderWHS]

Looks fixed on my end :) Yay!! I appreciate all the time an energy!!!

[bhoffman0]

@bnmnetp We've had reports of two more incidents of the code working on one server but not another: in email in 7.4.6.3.1 ActiveCode CookieOrder and https://discord.com/channels/1013815439161315348/1013892589776281620/1204144692174790686 on server1. All in Unit 7 but that might just be because that's where most classes are.
Maybe we should expand the cache clearing to files older than 2 days instead of 4?