readStream crash in iOS with new architecture enabled

[basilkurianmb]

While migrating react native to latest version 0.80.1

Enabled the new architecture

And using the latest react-native-blob-util version 0.22.0.

readStream method is crashing in iOS device(Android it is working).

Below mentioned is the crash logs.

terminating due to uncaught exception of type NSException
*** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '*** -[__NSPlaceholderDictionary initWithObjects:forKeys:count:]: attempt to insert nil object from objects[0]'
CoreSimulator 1010.15 - Device: iPhone 16 Pro Max (F1C10B56-90F1-44F7-84B6-B45F43F77B5F) - Runtime: iOS 18.5 (22F77) - DeviceType: iPhone 16 Pro Max

On further issue evaluation it is found that the streamId is coming as null in ReactNativeBlobUtilFS.mm -> readStream method. But, the streamId is getting generated in ReactNativeBlobUtilReadStream.js file.

Seems like after the streamId is generated and passed to native layer, the streamId is getting missed at iOS native layer.

[memberwebm]

i am having the same problem using readStream in ios, is there any way to fix it @RonRadtke @basilkurianmb

[basilkurianmb]

No solution found for this readStream in ios crash.

As an alternate solution, I changed from readStream to readFile method. That worked for me. This will only be a temporary fix.

[memberwebm]

if so then you can't read a large file of 500MB because the app will crash when reading base64 @basilkurianmb

[marius-styreportalen]

@basilkurianmb
I've spent way too much time trying to troubleshoot this issue. I'm not too familiar with objective-c, but from what I have found, it has to do with how the generated type for readStream is "double", while it expects "int". This causes an error where it misinterpret the 3. value, which causes an issue for the 4. and 5. values as well.

I don't know if this messes with something else, but I ended up with this fix, which seems to have solved it for me.

I've added a patch so you can easily patch it yourself for your react-native project.

react-native-blob-util+0.22.2.patch

diff --git a/node_modules/react-native-blob-util/ios/ReactNativeBlobUtil/ReactNativeBlobUtil.mm b/node_modules/react-native-blob-util/ios/ReactNativeBlobUtil/ReactNativeBlobUtil.mm
index 60f006a..07d8266 100644
--- a/node_modules/react-native-blob-util/ios/ReactNativeBlobUtil/ReactNativeBlobUtil.mm
+++ b/node_modules/react-native-blob-util/ios/ReactNativeBlobUtil/ReactNativeBlobUtil.mm
@@ -709,7 +709,7 @@ RCT_EXPORT_METHOD(hash:(NSString *)path
 }
 
 #pragma mark - fs.readStream
-RCT_EXPORT_METHOD(readStream:(NSString *)path encoding:(NSString *)encoding bufferSize:(int)bufferSize tick:(int)tick streamId:(NSString *)streamId)
+RCT_EXPORT_METHOD(readStream:(NSString *)path encoding:(NSString *)encoding bufferSize:(double)bufferSize tick:(double)tick streamId:(NSString *)streamId)
 {
     if(bufferSize == 0) {
         if([[encoding lowercaseString] isEqualToString:@"base64"])
diff --git a/node_modules/react-native-blob-util/ios/ReactNativeBlobUtilFS.h b/node_modules/react-native-blob-util/ios/ReactNativeBlobUtilFS.h
index f5267e0..e76bcf3 100644
--- a/node_modules/react-native-blob-util/ios/ReactNativeBlobUtilFS.h
+++ b/node_modules/react-native-blob-util/ios/ReactNativeBlobUtilFS.h
@@ -83,7 +83,7 @@
      rejecter:(RCTPromiseRejectBlock)reject;
 //+ (void) writeFileFromFile:(NSString *)src toFile:(NSString *)dest append:(BOOL)append;
 + (void) writeAssetToPath:(ALAssetRepresentation * )rep dest:(NSString *)dest;
-+ (void) readStream:(NSString *)uri encoding:(NSString * )encoding bufferSize:(int)bufferSize tick:(int)tick streamId:(NSString *)streamId baseModule:(ReactNativeBlobUtil *)baseModule;
++ (void) readStream:(NSString *)uri encoding:(NSString * )encoding bufferSize:(double)bufferSize tick:(double)tick streamId:(NSString *)streamId baseModule:(ReactNativeBlobUtil *)baseModule;
 + (void) df:(RCTResponseSenderBlock)callback;
 
 // constructor
diff --git a/node_modules/react-native-blob-util/ios/ReactNativeBlobUtilFS.mm b/node_modules/react-native-blob-util/ios/ReactNativeBlobUtilFS.mm
index b7f5972..68606f3 100644
--- a/node_modules/react-native-blob-util/ios/ReactNativeBlobUtilFS.mm
+++ b/node_modules/react-native-blob-util/ios/ReactNativeBlobUtilFS.mm
@@ -149,8 +149,8 @@ NSMutableDictionary *fileStreams = nil;
 
 + (void) readStream:(NSString *)uri
            encoding:(NSString * )encoding
-         bufferSize:(int)bufferSize
-               tick:(int)tick
+         bufferSize:(double)bufferSize
+               tick:(double)tick
            streamId:(NSString *)streamId
           baseModule:(ReactNativeBlobUtil*)baseModule
 {

[basilkurianmb]

@marius-styreportalen Thats great.

@RonRadtke - Could you able to confirm this fix and merge it with the upcoming release?

[pranavkumar389]

I tried the patch but it didn’t help. Anyone found another way around this?
@RonRadtke please have a look.

[dan-trewin]

FWIW, the patch did totally fix the issue in my app

[AlexMesser]

tnx @marius-styreportalen, the patch fixed the issue for me